Merge back changes from stable-1.5 #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bash 5 changed its rules somehow; let's protect the spaces to be safe.
pmempool_info/TEST26: SETUP (check/pmem/debug) ../unittest/unittest.sh: line 831: pool_hdr.shutdown_state.checksum_gen(): command not found pmempool_info/TEST26 failed with exit code 127. Ref: pmem/issues#1010
Quite a lot of tests passed with worrying messages. Some examples: compat_incompat_features/TEST0: SETUP (check/pmem/debug) ../unittest/unittest.sh: line 830: no match: pool_hdr.checksum_gen\(\) [MATCHING FAILED, COMPLETE FILE (out0.log) BELOW] [EOF] out0.log.match:1 compat_incompat_features/TEST0: START: compat_incompat_features out0.log:1 [EOF] FAIL: match: out0.log.match:1 did not match pattern compat_incompat_features/TEST0: PASS [00.290 s] pmempool_check/TEST28: SETUP (check/pmem/debug) ../unittest/unittest.sh: line 830: no match: pool_hdr.shutdown_state.checksum_gen\(\) [MATCHING FAILED, COMPLETE FILE (out28.log) BELOW] [EOF] out28.log.match:1 replica 0: an ADR failure was detected - your pool might be corrupted out28.log:1 [EOF] FAIL: match: out28.log.match:1 did not match pattern pmempool_check/TEST28: PASS [00.048 s] pmempool_info/TEST26: SETUP (check/pmem/debug) ../unittest/unittest.sh: line 830: no match: pool_hdr.shutdown_state.checksum_gen\(\) [MATCHING FAILED, COMPLETE FILE (out26.log) BELOW] (...) FAIL: match: out26.log.match:23 did not match pattern pmempool_info/TEST26: PASS [00.036 s] pmempool_sync/TEST12: SETUP (check/pmem/debug) ../unittest/unittest.sh: line 830: no match: pool_hdr.checksum_gen\(\) [MATCHING FAILED, COMPLETE FILE (out12.log) BELOW] pmempool_sync/TEST12 command succeeded unexpectedly. [EOF] out12.log.match:1 error: failed to synchronize: two consecutive unbroken parts are not linked to each other (repn 0, parts 0 and 1) - cannot synchronize out12.log:1 pmempool_sync/TEST12 command succeeded unexpectedly. FAIL: match: out12.log.match:1 did not match pattern pmempool_sync/TEST12: PASS [00.058 s] libpmempool_feature/TEST3: SETUP (check/pmem/debug) ../unittest/unittest.sh: line 830: no match: pool_hdr.checksum_gen\(\) libpmempool_feature/TEST3 command succeeded unexpectedly. ../unittest/unittest.sh: line 830: no match: pool_hdr.checksum_gen\(\) libpmempool_feature/TEST3 command succeeded unexpectedly. ../unittest/unittest.sh: line 830: no match: pool_hdr.checksum_gen\(\) libpmempool_feature/TEST3 command succeeded unexpectedly. [MATCHING FAILED, COMPLETE FILE (grep3.log) BELOW] [EOF] grep3.log.match:1 $(*)pool.obj: spoil: pool_hdr.features.compat=0xfe grep3.log:1 [EOF] FAIL: match: grep3.log.match:1 did not match pattern libpmempool_feature/TEST3: PASS [00.083 s] rpmem_addr/TEST0: SETUP (check/none/debug) ../unittest/unittest.sh: line 830: no match: user@\[::1\]:1234 match: out0.log: No such file or directory Usage: match [-adqv] [match-file]... or: match [-dqv] -o output-file match-file... rpmem_addr/TEST0: PASS [00.021 s] Ref: pmem/issues#1010
bash 5 changed the order again See also: 9dbfabc
test: fix one of failing bash-5 tests
Should be done upstream, but...
test: various fixes (mostly bash 5 related)
common: fix librpmem package dependency on suse
test: valgrind suppressions for glibc 2.28
doc: rpmem_deep_persist was missing
doc: fix manpage alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is