Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: various fixes (mostly bash 5 related) #3554

Merged
merged 6 commits into from
Feb 7, 2019

Conversation

marcinslusarz
Copy link
Contributor

@marcinslusarz marcinslusarz commented Feb 6, 2019

This change is Reviewable

pmempool_info/TEST26: SETUP (check/pmem/debug)
../unittest/unittest.sh: line 831: pool_hdr.shutdown_state.checksum_gen(): command not found
pmempool_info/TEST26 failed with exit code 127.

Ref: pmem/issues#1010
Quite a lot of tests passed with worrying messages. Some examples:

compat_incompat_features/TEST0: SETUP (check/pmem/debug)
../unittest/unittest.sh: line 830: no match: pool_hdr.checksum_gen\(\)
[MATCHING FAILED, COMPLETE FILE (out0.log) BELOW]

[EOF]
out0.log.match:1   compat_incompat_features/TEST0: START: compat_incompat_features
out0.log:1         [EOF]
FAIL: match: out0.log.match:1 did not match pattern
compat_incompat_features/TEST0: PASS                    [00.290 s]

pmempool_check/TEST28: SETUP (check/pmem/debug)
../unittest/unittest.sh: line 830: no match: pool_hdr.shutdown_state.checksum_gen\(\)
[MATCHING FAILED, COMPLETE FILE (out28.log) BELOW]

[EOF]
out28.log.match:1   replica 0: an ADR failure was detected - your pool might be corrupted
out28.log:1         [EOF]
FAIL: match: out28.log.match:1 did not match pattern
pmempool_check/TEST28: PASS                     [00.048 s]

pmempool_info/TEST26: SETUP (check/pmem/debug)
../unittest/unittest.sh: line 830: no match: pool_hdr.shutdown_state.checksum_gen\(\)
[MATCHING FAILED, COMPLETE FILE (out26.log) BELOW]
(...)
FAIL: match: out26.log.match:23 did not match pattern
pmempool_info/TEST26: PASS                      [00.036 s]

pmempool_sync/TEST12: SETUP (check/pmem/debug)
../unittest/unittest.sh: line 830: no match: pool_hdr.checksum_gen\(\)
[MATCHING FAILED, COMPLETE FILE (out12.log) BELOW]
pmempool_sync/TEST12 command succeeded unexpectedly.

[EOF]
out12.log.match:1   error: failed to synchronize: two consecutive unbroken parts are not linked to each other (repn 0, parts 0 and 1) - cannot synchronize
out12.log:1         pmempool_sync/TEST12 command succeeded unexpectedly.
FAIL: match: out12.log.match:1 did not match pattern
pmempool_sync/TEST12: PASS                      [00.058 s]

libpmempool_feature/TEST3: SETUP (check/pmem/debug)
../unittest/unittest.sh: line 830: no match: pool_hdr.checksum_gen\(\)
libpmempool_feature/TEST3 command succeeded unexpectedly.
../unittest/unittest.sh: line 830: no match: pool_hdr.checksum_gen\(\)
libpmempool_feature/TEST3 command succeeded unexpectedly.
../unittest/unittest.sh: line 830: no match: pool_hdr.checksum_gen\(\)
libpmempool_feature/TEST3 command succeeded unexpectedly.
[MATCHING FAILED, COMPLETE FILE (grep3.log) BELOW]

[EOF]
grep3.log.match:1   $(*)pool.obj: spoil: pool_hdr.features.compat=0xfe
grep3.log:1         [EOF]
FAIL: match: grep3.log.match:1 did not match pattern
libpmempool_feature/TEST3: PASS                 [00.083 s]

rpmem_addr/TEST0: SETUP (check/none/debug)
../unittest/unittest.sh: line 830: no match: user@\[::1\]:1234
match: out0.log: No such file or directory
Usage: match [-adqv] [match-file]...
   or: match [-dqv] -o output-file match-file...
rpmem_addr/TEST0: PASS                  [00.021 s]

Ref: pmem/issues#1010
bash 5 changed the order again

See also: 9dbfabc
@marcinslusarz marcinslusarz changed the base branch from master to stable-1.5 February 6, 2019 16:41
@pmem-bot
Copy link
Contributor

pmem-bot commented Feb 6, 2019

@janekmi and @Greg091 please review this pull request

Copy link
Contributor

@kilobyte kilobyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link

@Greg091 Greg091 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@marcinslusarz marcinslusarz merged commit 1ef871f into pmem:stable-1.5 Feb 7, 2019
@marcinslusarz marcinslusarz deleted the fixes branch February 25, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants