Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Let plugin take care of sitemap #212

Closed
wants to merge 0 commits into from
Closed

Let plugin take care of sitemap #212

wants to merge 0 commits into from

Conversation

pathawks
Copy link
Contributor

@pathawks pathawks commented May 8, 2014

Related to #211

No need to reinvent the wheel, we can use the jekyll-sitemap plugin.

This is fully supported by GitHub pages.

@pathawks pathawks closed this Mar 22, 2015
@groundh0g
Copy link
Collaborator

Hey, @pathawks. Why'd you close the PR? Looks like you made the suggestion and it was implemented in the gh-pages branch, but not master?

I'd like to see support for this and the other supported plugins added.

https://help.github.com/articles/using-jekyll-plugins-with-github-pages/

You just doing a little spring cleaning?

@pathawks
Copy link
Contributor Author

Honestly, it was a mistake. The pull request was from my master branch; when I rebased my master the pull request went away.

I have opened a new pull request (from on it's own branch) #257.

Yes, it was implemented in the gh-pages branch in #211, but not master.

@groundh0g
Copy link
Collaborator

I'm reviewing issues, not PRs, so I'll create one to track this. There are 3 planned milestones to get us to version 1.0.0. I'd like to add yours to that last one, since it's in the spirit of using latest Jekyll and GitHub Pages features. Thanks for your contribution, and for your patience.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants