Skip to content

Clean-up _collect_energy_pulses() #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Clean-up _collect_energy_pulses() #129

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90b68a9
Clean-up _collect_energy_pulses()
bouwew Jan 4, 2024
cdd15ec
else if -> elif
bouwew Jan 4, 2024
8f2b6bf
Revert and fix
bouwew Jan 4, 2024
664721b
Revert ident-change as requested
bouwew Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions plugwise_usb/nodes/circle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,13 +422,9 @@ def _collect_energy_pulses(self, start_utc: datetime, end_utc: datetime):
if self._energy_history_failed_address.count(_mem_address) == 0:
self._energy_history_failed_address.append(_mem_address)
_LOGGER.info(
"_collect_energy_pulses for %s at %s not found, request counter from memory %s (from mem=%s, slot=%s, timestamp=%s)",
"_collect_energy_pulses for %s at %s not found",
self.mac,
str(_log_timestamp),
str(_mem_address),
str(self._last_log_address),
str(self._energy_last_populated_slot),
str(self._energy_last_collected_timestamp),
)

# Validate all history values where present
Expand Down