Clean-up _collect_energy_pulses() #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
=======================================
Coverage 34.84% 34.84%
=======================================
Files 21 21
Lines 2425 2425
=======================================
Hits 845 845
Misses 1580 1580 ☔ View full report in Codecov by Sentry. |
Contributor
|
In the end-result you have moved the _LOGGER.info inside the if clause, this was intentionally kept under the else because even thought the address is already inside _energy_history_failed_address list, we still want to be able to trace the repeated failing. |
dirixmjm
requested changes
Jan 4, 2024
Contributor
dirixmjm
left a comment
dirixmjm
left a comment
There was a problem hiding this comment.
Please move _LOGGER.info back under the else.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.