Skip to content

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Nov 17, 2025

Summary by CodeRabbit

  • Chores

    • Reclassified multiple Plugwise sensors and binary sensors as diagnostics so they appear in the diagnostics category rather than primary device controls.
    • Bumped package version to v0.61.0.
  • Documentation

    • Added a v0.61.0 changelog entry noting the diagnostics classification update and related references.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 17, 2025

Walkthrough

Adds EntityCategory.DIAGNOSTIC to multiple Plugwise sensor and binary sensor entity descriptions and bumps the package version/changelog to v0.61.0. No runtime logic or control flow is changed.

Changes

Cohort / File(s) Summary
Binary sensor metadata
custom_components/plugwise/binary_sensor.py
Add entity_category=EntityCategory.DIAGNOSTIC to binary sensor descriptions: DHW_STATE, HEATING_STATE, COOLING_STATE, PLUGWISE_NOTIFICATION.
Sensor metadata
custom_components/plugwise/sensor.py
Add entity_category=EntityCategory.DIAGNOSTIC to multiple sensor descriptions, including INTENDED_BOILER_TEMP, TEMP_DIFF, OUTDOOR_TEMP, WATER_TEMP, RETURN_TEMP, battery, illuminance, VALVE_POS, DHW_TEMP, DHW_SETPOINT, and related entries.
Version & changelog
custom_components/plugwise/manifest.json, pyproject.toml, CHANGELOG.md
Bump version from 0.60.0 to 0.61.0 and replace ## Ongoing with ## v0.61.0 plus a bullet about diagnostics category alignment (PR references).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify each listed entity description uses EntityCategory.DIAGNOSTIC (no typos, correct import).
  • Ensure no unintended changes to translation_key, state_class, or units.
  • Confirm manifest/pyproject version strings and CHANGELOG formatting.

Possibly related PRs

Suggested labels

require-dev-pass

Suggested reviewers

  • CoMPaTech

Poem

🐰 I hopped through lines both neat and small,
Labeled diagnostics for one and all,
Valves and temps in tidy array,
A carrot-coded, metadata ballet! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Line up diagnostics configs with Core' directly relates to the main change: adding entity_category=EntityCategory.DIAGNOSTIC to multiple sensor and binary sensor descriptions to align with Core Plugwise standards, as confirmed by the CHANGELOG entry referencing PR #965.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch core-diag

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf03d15 and 47b3cdc.

📒 Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • custom_components/plugwise/manifest.json (1 hunks)
  • pyproject.toml (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • custom_components/plugwise/manifest.json
  • CHANGELOG.md
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-01-25T20:42:24.862Z
Learnt from: CoMPaTech
Repo: plugwise/plugwise-beta PR: 0
File: :0-0
Timestamp: 2025-01-25T20:42:24.862Z
Learning: In the plugwise-beta project, `uv` package manager was removed from core-testing.sh in favor of pip due to issues it was causing.

Applied to files:

  • pyproject.toml
📚 Learning: 2024-09-27T09:48:30.890Z
Learnt from: bouwew
Repo: plugwise/plugwise-beta PR: 734
File: tests/components/plugwise/test_config_flow.py:58-58
Timestamp: 2024-09-27T09:48:30.890Z
Learning: In `tests/components/plugwise/test_config_flow.py`, the versions are mocked firmware versions for testing purposes and do not need to match the software version in `manifest.json`.

Applied to files:

  • pyproject.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Prepare and validate pre-commit
🔇 Additional comments (1)
pyproject.toml (1)

3-3: Version consistency verified across all configuration files.

The version bump from 0.60.0 to 0.61.0 is correctly applied to pyproject.toml (line 3), manifest.json, and CHANGELOG.md. All files are aligned and consistent.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bouwew bouwew marked this pull request as ready for review November 17, 2025 09:46
@bouwew bouwew requested a review from a team as a code owner November 17, 2025 09:46
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
CHANGELOG.md (1)

5-8: Consider clarifying the relationship between the two diagnostics-related entries.

Lines 7 and 8 both reference issue #810 and PR #952 in the context of diagnostics category assignments. While the progression (revisit → final solution) is clear, back-to-back entries on the same topic might reduce clarity for users reviewing the changelog. Consider either merging these entries or adding a brief clarification about what makes PR #965 the "final solution" relative to PR #952's "revisit."

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d608c9c and bf03d15.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)

@sonarqubecloud
Copy link

@bouwew bouwew merged commit 02ed584 into main Nov 17, 2025
13 checks passed
@bouwew bouwew deleted the core-diag branch November 17, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants