Skip to content

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Nov 3, 2025

Summary by CodeRabbit

  • Style
    • Several sensors and binary sensors are no longer marked as "diagnostic", which may change how they appear, are filtered, or are grouped in device lists and dashboards.
  • New Features
    • The schedule selector is now categorized as a configuration control, affecting where it appears in the UI.
  • Documentation
    • Changelog updated to note revisiting diagnostic category assignments.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 3, 2025

Walkthrough

Removed EntityCategory.DIAGNOSTIC from many Plugwise sensor and binary_sensor entity descriptions and added EntityCategory.CONFIG to one select description; all changes are metadata-only with no control flow or data retrieval edits.

Changes

Cohort / File(s) Summary
Sensors — diagnostic flag removals
custom_components/plugwise/sensor.py
Removed entity_category=EntityCategory.DIAGNOSTIC from numerous PlugwiseSensorEntityDescription entries (e.g., TARGET_TEMP, TARGET_TEMP_HIGH, TARGET_TEMP_LOW, ATTR_TEMPERATURE, INTENDED_BOILER_TEMP, TEMP_DIFF, OUTDOOR_AIR_TEMP, WATER_TEMP, VALVE_POS, WATER_PRESSURE, DHW_TEMP, DHW_SETPOINT, and related entries). Metadata-only change.
Binary sensors — diagnostic flag removals
custom_components/plugwise/binary_sensor.py
Removed entity_category=EntityCategory.DIAGNOSTIC from several PlugwiseBinarySensorEntityDescription entries (e.g., BATTERY_STATE, COMPRESSOR_STATE, COOLING_ENABLED, DHW_STATE, HEATING_STATE, COOLING_STATE, PLUGWISE_NOTIFICATION). FLAME_STATE and SECONDARY_BOILER_STATE retain DIAGNOSTIC. Metadata-only change.
Select — config category addition
custom_components/plugwise/select.py
Added entity_category=EntityCategory.CONFIG to the SELECT_SCHEDULE entry in SELECT_TYPES. Metadata-only change.
Changelog
CHANGELOG.md
Added an entry under Ongoing referencing revisiting diagnostics category assignments (issue #810 / PR #952). Documentation-only change.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Multiple files with similar metadata edits — moderate review to confirm only entity_category fields changed.
  • Areas to check:
    • Ensure no unintended edits to imports, spacing, or other fields in sensor.py, binary_sensor.py, select.py.
    • Verify that retained DIAGNOSTIC entries (e.g., FLAME_STATE, SECONDARY_BOILER_STATE) remain correct.
    • Confirm no external code assumes those sensors/binary_sensors were categorized as DIAGNOSTIC.

Suggested labels

require-dev-pass

Suggested reviewers

  • CoMPaTech

Poem

🐰
I nibble tags in gentle hops,
I drop old diagnostics from the crops.
One select now wears a config crown,
I tidy labels, then hop down. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main changes: removing diagnostics category from climate-zone temperature sensors and other sensor types (battery, illuminance, and state sensors).
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove_diagn

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bouwew bouwew force-pushed the remove_diagn branch 2 times, most recently from fd2f683 to af4667a Compare November 9, 2025 09:44
@bouwew bouwew marked this pull request as ready for review November 10, 2025 07:31
@bouwew bouwew requested a review from a team as a code owner November 10, 2025 07:31
@sonarqubecloud
Copy link

@bouwew bouwew self-assigned this Nov 10, 2025
@bouwew
Copy link
Contributor Author

bouwew commented Nov 10, 2025

Solution for plugwise/python-plugwise#810

@bouwew bouwew changed the title Request: remove diagnostics category from climate-zone temperature sensors Request: remove diagnostics category from climate-zone temperature sensors and more Nov 10, 2025
@bouwew bouwew merged commit 53b8914 into main Nov 10, 2025
13 checks passed
@bouwew bouwew deleted the remove_diagn branch November 10, 2025 12:30
bouwew added a commit that referenced this pull request Nov 10, 2025
Fix missed snapshot updates in #952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants