Skip to content

Plug back v1.49.5 onto master #4202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 18, 2019
Merged

Plug back v1.49.5 onto master #4202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ae8a00
fix #4194 - stringify locations[i] for hover pointData
etpinard Sep 17, 2019
d387ea8
add clearPromiseQueue to Plotly.react
etpinard Sep 17, 2019
e24d205
do not attempt to remove non-existant source and layers
etpinard Sep 17, 2019
3320438
ensure that all tile source items are non-empty strings
etpinard Sep 17, 2019
f1ca22c
update changelog for 1.49.5
etpinard Sep 18, 2019
9705bb7
1.49.5
etpinard Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,15 @@ https://github.com/plotly/plotly.js/compare/vX.Y.Z...master
where X.Y.Z is the semver of most recent plotly.js release.


## [1.49.5] -- 2019-09-18

### Fixed
- Clear rejected promises from queue when calling `Plotly.react` [#4197]
- Do not attempt to remove non-existing mapbox layout source and layers [#4197]
- Invalid mapbox layout layers with blank-string tile entries [#4197]
- Fix hover labels for `choroplethmapbox` with number `locations` items [#4197]


## [1.49.4] -- 2019-08-22

### Fixed
Expand Down
36 changes: 18 additions & 18 deletions dist/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ object. This property must be set before the plotly.js script tag, for example:
Plotly.js defaults to US English (en-US) and includes British English (en) in the standard bundle.
Many other localizations are available - here is an example using Swiss-German (de-CH),
see the contents of this directory for the full list.
They are also available on our CDN as https://cdn.plot.ly/plotly-locale-de-ch-latest.js OR https://cdn.plot.ly/plotly-locale-de-ch-1.49.4.js
They are also available on our CDN as https://cdn.plot.ly/plotly-locale-de-ch-latest.js OR https://cdn.plot.ly/plotly-locale-de-ch-1.49.5.js
Note that the file names are all lowercase, even though the region is uppercase when you apply a locale.

*After* the plotly.js script tag, add:
Expand All @@ -74,12 +74,12 @@ The main plotly.js bundle includes all the official (non-beta) trace modules.

It be can imported as minified javascript
- using dist file `dist/plotly.min.js`
- using CDN URL https://cdn.plot.ly/plotly-latest.min.js OR https://cdn.plot.ly/plotly-1.49.4.min.js
- using CDN URL https://cdn.plot.ly/plotly-latest.min.js OR https://cdn.plot.ly/plotly-1.49.5.min.js

or as raw javascript:
- using the `plotly.js-dist` npm package (starting in `v1.39.0`)
- using dist file `dist/plotly.js`
- using CDN URL https://cdn.plot.ly/plotly-latest.js OR https://cdn.plot.ly/plotly-1.49.4.js
- using CDN URL https://cdn.plot.ly/plotly-latest.js OR https://cdn.plot.ly/plotly-1.49.5.js
- using CommonJS with `require('plotly.js')`

If you would like to have access to the attribute meta information (including attribute descriptions as on the [schema reference page](https://plot.ly/javascript/reference/)), use dist file `dist/plotly-with-meta.js`
Expand Down Expand Up @@ -119,8 +119,8 @@ The `basic` partial bundle contains trace modules `scatter`, `bar` and `pie`.
| ------ | --- |
| Latest | https://cdn.plot.ly/plotly-basic-latest.js |
| Latest minified | https://cdn.plot.ly/plotly-basic-latest.min.js |
| Tagged | https://cdn.plot.ly/plotly-basic-1.49.4.js |
| Tagged minified | https://cdn.plot.ly/plotly-basic-1.49.4.min.js |
| Tagged | https://cdn.plot.ly/plotly-basic-1.49.5.js |
| Tagged minified | https://cdn.plot.ly/plotly-basic-1.49.5.min.js |

#### npm package (starting in `v1.39.0`)

Expand Down Expand Up @@ -165,8 +165,8 @@ The `cartesian` partial bundle contains trace modules `scatter`, `bar`, `box`, `
| ------ | --- |
| Latest | https://cdn.plot.ly/plotly-cartesian-latest.js |
| Latest minified | https://cdn.plot.ly/plotly-cartesian-latest.min.js |
| Tagged | https://cdn.plot.ly/plotly-cartesian-1.49.4.js |
| Tagged minified | https://cdn.plot.ly/plotly-cartesian-1.49.4.min.js |
| Tagged | https://cdn.plot.ly/plotly-cartesian-1.49.5.js |
| Tagged minified | https://cdn.plot.ly/plotly-cartesian-1.49.5.min.js |

#### npm package (starting in `v1.39.0`)

Expand Down Expand Up @@ -211,8 +211,8 @@ The `geo` partial bundle contains trace modules `scatter`, `scattergeo` and `cho
| ------ | --- |
| Latest | https://cdn.plot.ly/plotly-geo-latest.js |
| Latest minified | https://cdn.plot.ly/plotly-geo-latest.min.js |
| Tagged | https://cdn.plot.ly/plotly-geo-1.49.4.js |
| Tagged minified | https://cdn.plot.ly/plotly-geo-1.49.4.min.js |
| Tagged | https://cdn.plot.ly/plotly-geo-1.49.5.js |
| Tagged minified | https://cdn.plot.ly/plotly-geo-1.49.5.min.js |

#### npm package (starting in `v1.39.0`)

Expand Down Expand Up @@ -257,8 +257,8 @@ The `gl3d` partial bundle contains trace modules `scatter`, `scatter3d`, `surfac
| ------ | --- |
| Latest | https://cdn.plot.ly/plotly-gl3d-latest.js |
| Latest minified | https://cdn.plot.ly/plotly-gl3d-latest.min.js |
| Tagged | https://cdn.plot.ly/plotly-gl3d-1.49.4.js |
| Tagged minified | https://cdn.plot.ly/plotly-gl3d-1.49.4.min.js |
| Tagged | https://cdn.plot.ly/plotly-gl3d-1.49.5.js |
| Tagged minified | https://cdn.plot.ly/plotly-gl3d-1.49.5.min.js |

#### npm package (starting in `v1.39.0`)

Expand Down Expand Up @@ -303,8 +303,8 @@ The `gl2d` partial bundle contains trace modules `scatter`, `scattergl`, `splom`
| ------ | --- |
| Latest | https://cdn.plot.ly/plotly-gl2d-latest.js |
| Latest minified | https://cdn.plot.ly/plotly-gl2d-latest.min.js |
| Tagged | https://cdn.plot.ly/plotly-gl2d-1.49.4.js |
| Tagged minified | https://cdn.plot.ly/plotly-gl2d-1.49.4.min.js |
| Tagged | https://cdn.plot.ly/plotly-gl2d-1.49.5.js |
| Tagged minified | https://cdn.plot.ly/plotly-gl2d-1.49.5.min.js |

#### npm package (starting in `v1.39.0`)

Expand Down Expand Up @@ -341,16 +341,16 @@ The `mapbox` partial bundle contains trace modules `scatter`, `scattermapbox`, `

| Raw size | Minified size | Minified + gzip size |
|------|-----------------|------------------------|
| 3.1 MB | 1.5 MB | 456.3 kB |
| 3.1 MB | 1.5 MB | 456.4 kB |

#### CDN links

| Flavor | URL |
| ------ | --- |
| Latest | https://cdn.plot.ly/plotly-mapbox-latest.js |
| Latest minified | https://cdn.plot.ly/plotly-mapbox-latest.min.js |
| Tagged | https://cdn.plot.ly/plotly-mapbox-1.49.4.js |
| Tagged minified | https://cdn.plot.ly/plotly-mapbox-1.49.4.min.js |
| Tagged | https://cdn.plot.ly/plotly-mapbox-1.49.5.js |
| Tagged minified | https://cdn.plot.ly/plotly-mapbox-1.49.5.min.js |

#### npm package (starting in `v1.39.0`)

Expand Down Expand Up @@ -395,8 +395,8 @@ The `finance` partial bundle contains trace modules `scatter`, `bar`, `histogram
| ------ | --- |
| Latest | https://cdn.plot.ly/plotly-finance-latest.js |
| Latest minified | https://cdn.plot.ly/plotly-finance-latest.min.js |
| Tagged | https://cdn.plot.ly/plotly-finance-1.49.4.js |
| Tagged minified | https://cdn.plot.ly/plotly-finance-1.49.4.min.js |
| Tagged | https://cdn.plot.ly/plotly-finance-1.49.5.js |
| Tagged minified | https://cdn.plot.ly/plotly-finance-1.49.5.min.js |

#### npm package (starting in `v1.39.0`)

Expand Down
5 changes: 3 additions & 2 deletions dist/plotly-basic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* plotly.js (basic) v1.49.4
* plotly.js (basic) v1.49.5
* Copyright 2012-2019, Plotly, Inc.
* All rights reserved.
* Licensed under the MIT license
Expand Down Expand Up @@ -33991,7 +33991,7 @@ exports.svgAttrs = {
'use strict';

// package version injected by `npm run preprocess`
exports.version = '1.49.4';
exports.version = '1.49.5';

// inject promise polyfill
_dereq_('es6-promise').polyfill();
Expand Down Expand Up @@ -44433,6 +44433,7 @@ function react(gd, data, layout, config) {
function addFrames() { return exports.addFrames(gd, frames); }

gd = Lib.getGraphDiv(gd);
helpers.clearPromiseQueue(gd);

var oldFullData = gd._fullData;
var oldFullLayout = gd._fullLayout;
Expand Down
4 changes: 2 additions & 2 deletions dist/plotly-basic.min.js
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions dist/plotly-cartesian.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* plotly.js (cartesian) v1.49.4
* plotly.js (cartesian) v1.49.5
* Copyright 2012-2019, Plotly, Inc.
* All rights reserved.
* Licensed under the MIT license
Expand Down Expand Up @@ -34141,7 +34141,7 @@ exports.svgAttrs = {
'use strict';

// package version injected by `npm run preprocess`
exports.version = '1.49.4';
exports.version = '1.49.5';

// inject promise polyfill
_dereq_('es6-promise').polyfill();
Expand Down Expand Up @@ -44583,6 +44583,7 @@ function react(gd, data, layout, config) {
function addFrames() { return exports.addFrames(gd, frames); }

gd = Lib.getGraphDiv(gd);
helpers.clearPromiseQueue(gd);

var oldFullData = gd._fullData;
var oldFullLayout = gd._fullLayout;
Expand Down
4 changes: 2 additions & 2 deletions dist/plotly-cartesian.min.js
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions dist/plotly-finance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* plotly.js (finance) v1.49.4
* plotly.js (finance) v1.49.5
* Copyright 2012-2019, Plotly, Inc.
* All rights reserved.
* Licensed under the MIT license
Expand Down Expand Up @@ -34111,7 +34111,7 @@ exports.svgAttrs = {
'use strict';

// package version injected by `npm run preprocess`
exports.version = '1.49.4';
exports.version = '1.49.5';

// inject promise polyfill
_dereq_('es6-promise').polyfill();
Expand Down Expand Up @@ -44553,6 +44553,7 @@ function react(gd, data, layout, config) {
function addFrames() { return exports.addFrames(gd, frames); }

gd = Lib.getGraphDiv(gd);
helpers.clearPromiseQueue(gd);

var oldFullData = gd._fullData;
var oldFullLayout = gd._fullLayout;
Expand Down
4 changes: 2 additions & 2 deletions dist/plotly-finance.min.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/plotly-geo-assets.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions dist/plotly-geo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* plotly.js (geo) v1.49.4
* plotly.js (geo) v1.49.5
* Copyright 2012-2019, Plotly, Inc.
* All rights reserved.
* Licensed under the MIT license
Expand Down Expand Up @@ -34770,7 +34770,7 @@ exports.svgAttrs = {
'use strict';

// package version injected by `npm run preprocess`
exports.version = '1.49.4';
exports.version = '1.49.5';

// inject promise polyfill
_dereq_('es6-promise').polyfill();
Expand Down Expand Up @@ -45443,6 +45443,7 @@ function react(gd, data, layout, config) {
function addFrames() { return exports.addFrames(gd, frames); }

gd = Lib.getGraphDiv(gd);
helpers.clearPromiseQueue(gd);

var oldFullData = gd._fullData;
var oldFullLayout = gd._fullLayout;
Expand Down Expand Up @@ -70104,6 +70105,7 @@ function makeHoverInfo(pointData, trace, pt) {
if(trace.hovertemplate) return;

var hoverinfo = pt.hi || trace.hoverinfo;
var loc = String(pt.loc);

var parts = (hoverinfo === 'all') ?
attributes.hoverinfo.flags :
Expand All @@ -70118,10 +70120,10 @@ function makeHoverInfo(pointData, trace, pt) {
var text = [];

if(hasIdAsNameLabel) {
pointData.nameOverride = pt.loc;
pointData.nameOverride = loc;
} else {
if(hasName) pointData.nameOverride = trace.name;
if(hasLocation) text.push(pt.loc);
if(hasLocation) text.push(loc);
}

if(hasZ) {
Expand Down
4 changes: 2 additions & 2 deletions dist/plotly-geo.min.js
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions dist/plotly-gl2d.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* plotly.js (gl2d) v1.49.4
* plotly.js (gl2d) v1.49.5
* Copyright 2012-2019, Plotly, Inc.
* All rights reserved.
* Licensed under the MIT license
Expand Down Expand Up @@ -67737,7 +67737,7 @@ exports.svgAttrs = {
'use strict';

// package version injected by `npm run preprocess`
exports.version = '1.49.4';
exports.version = '1.49.5';

// inject promise polyfill
_dereq_('es6-promise').polyfill();
Expand Down Expand Up @@ -78476,6 +78476,7 @@ function react(gd, data, layout, config) {
function addFrames() { return exports.addFrames(gd, frames); }

gd = Lib.getGraphDiv(gd);
helpers.clearPromiseQueue(gd);

var oldFullData = gd._fullData;
var oldFullLayout = gd._fullLayout;
Expand Down
4 changes: 2 additions & 2 deletions dist/plotly-gl2d.min.js
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions dist/plotly-gl3d.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* plotly.js (gl3d) v1.49.4
* plotly.js (gl3d) v1.49.5
* Copyright 2012-2019, Plotly, Inc.
* All rights reserved.
* Licensed under the MIT license
Expand Down Expand Up @@ -74214,7 +74214,7 @@ exports.svgAttrs = {
'use strict';

// package version injected by `npm run preprocess`
exports.version = '1.49.4';
exports.version = '1.49.5';

// inject promise polyfill
_dereq_('es6-promise').polyfill();
Expand Down Expand Up @@ -84845,6 +84845,7 @@ function react(gd, data, layout, config) {
function addFrames() { return exports.addFrames(gd, frames); }

gd = Lib.getGraphDiv(gd);
helpers.clearPromiseQueue(gd);

var oldFullData = gd._fullData;
var oldFullLayout = gd._fullLayout;
Expand Down
4 changes: 2 additions & 2 deletions dist/plotly-gl3d.min.js
View file
Open in desktop

Large diffs are not rendered by default.

31 changes: 21 additions & 10 deletions dist/plotly-mapbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* plotly.js (mapbox) v1.49.4
* plotly.js (mapbox) v1.49.5
* Copyright 2012-2019, Plotly, Inc.
* All rights reserved.
* Licensed under the MIT license
Expand Down Expand Up @@ -36847,7 +36847,7 @@ exports.svgAttrs = {
'use strict';

// package version injected by `npm run preprocess`
exports.version = '1.49.4';
exports.version = '1.49.5';

// inject promise polyfill
_dereq_('es6-promise').polyfill();
Expand Down Expand Up @@ -47520,6 +47520,7 @@ function react(gd, data, layout, config) {
function addFrames() { return exports.addFrames(gd, frames); }

gd = Lib.getGraphDiv(gd);
helpers.clearPromiseQueue(gd);

var oldFullData = gd._fullData;
var oldFullLayout = gd._fullLayout;
Expand Down Expand Up @@ -64023,17 +64024,26 @@ proto.removeLayer = function() {

proto.dispose = function() {
var map = this.subplot.map;
map.removeLayer(this.idLayer);
map.removeSource(this.idSource);
if(map.getLayer(this.idLayer)) map.removeLayer(this.idLayer);
if(map.getSource(this.idSource)) map.removeSource(this.idSource);
};

function isVisible(opts) {
if(!opts.visible) return false;

var source = opts.source;

return opts.visible && (
Lib.isPlainObject(source) ||
((typeof source === 'string' || Array.isArray(source)) && source.length > 0)
);
if(Array.isArray(source) && source.length > 0) {
for(var i = 0; i < source.length; i++) {
if(typeof source[i] !== 'string' || source[i].length === 0) {
return false;
}
}
return true;
}

return Lib.isPlainObject(source) ||
(typeof source === 'string' && source.length > 0);
}

function convertOpts(opts) {
Expand Down Expand Up @@ -71866,6 +71876,7 @@ function makeHoverInfo(pointData, trace, pt) {
if(trace.hovertemplate) return;

var hoverinfo = pt.hi || trace.hoverinfo;
var loc = String(pt.loc);

var parts = (hoverinfo === 'all') ?
attributes.hoverinfo.flags :
Expand All @@ -71880,10 +71891,10 @@ function makeHoverInfo(pointData, trace, pt) {
var text = [];

if(hasIdAsNameLabel) {
pointData.nameOverride = pt.loc;
pointData.nameOverride = loc;
} else {
if(hasName) pointData.nameOverride = trace.name;
if(hasLocation) text.push(pt.loc);
if(hasLocation) text.push(loc);
}

if(hasZ) {
Expand Down
4 changes: 2 additions & 2 deletions dist/plotly-mapbox.min.js
View file
Open in desktop

Large diffs are not rendered by default.

Loading