Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email delivery error handling #192

Merged
merged 1 commit into from
May 25, 2020
Merged

Add email delivery error handling #192

merged 1 commit into from
May 25, 2020

Conversation

Yam-s
Copy link
Contributor

@Yam-s Yam-s commented May 25, 2020

#191

Wrapped the email sending in try-catches to gracefully display an error telling the user to contact an admin.
image
I think creating a mail queue and using supervisor (optional?) to send unsent emails should be considered.

SendUserFileChanged.php has no error message because the page doesn't refresh/change when you click save, the error message would show up on a different page which might be confusing.

@itsrachelfish
Copy link
Member

Awesome! Thanks for getting this fixed so quickly

@itsrachelfish itsrachelfish merged commit 12ed724 into playasoft:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants