Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protected pod against eviction with system known annotation #76

Merged
merged 2 commits into from
Apr 28, 2020
Merged

protected pod against eviction with system known annotation #76

merged 2 commits into from
Apr 28, 2020

Conversation

dbenque
Copy link
Contributor

@dbenque dbenque commented Apr 17, 2020

implements #73

@codecov
Copy link

codecov bot commented Apr 17, 2020 •
edited
Loading

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   69.84%   69.84%           
=======================================
  Files           7        7           
  Lines         461      461           
=======================================
  Hits          322      322           
  Misses        130      130           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f82ca0...e42f3fc. Read the comment docs.

jacobstr
jacobstr approved these changes Apr 18, 2020
View reviewed changes
Copy link
Contributor

@jacobstr jacobstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo nit. Cheers.

README.md Outdated
@@ -69,6 +69,9 @@ Keep the following in mind before deploying Draino:
* Draino considers a drain to have failed if at least one pod eviction triggered
by that drain fails. If Draino fails to evict two of five pods it will consider
the Drain to have failed, but the remaining three pods will always be evicted.
* Pods that can't be evited by the cluster-autoscaler won't be evicted by draino.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that can't be evicted

@dbenque
Copy link
Contributor Author

dbenque commented Apr 21, 2020

@jacobstr thanks for the review. PR updated with typo fix.

@jacobstr jacobstr merged commit 8718f74 into planetlabs:master Apr 28, 2020
@dbenque dbenque deleted the david.benque/cluster-autoscaler-evict-annotation branch September 30, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobstr jacobstr jacobstr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbenque @jacobstr