Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider Cluster-Autoscaler safe-to-evict annotation by default #73

Closed
dbenque opened this issue Mar 30, 2020 · 1 comment
Closed

Consider Cluster-Autoscaler safe-to-evict annotation by default #73

dbenque opened this issue Mar 30, 2020 · 1 comment

Comments

@dbenque
Copy link
Contributor

dbenque commented Mar 30, 2020

Draino should not evict pods that are marked with
"cluster-autoscaler.kubernetes.io/safe-to-evict": "false"

https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/FAQ.md#what-types-of-pods-can-prevent-ca-from-removing-a-node

I can do the PR if there is an agreement on that.
@jacobstr
Copy link
Contributor

Sounds like a net win vs. the coarse approach of opting in to evict-daemonset/evict-statefulset etc.

@dbenque dbenque mentioned this issue Apr 17, 2020
Merged
@dbenque dbenque closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobstr @dbenque