Fix socket connection bug #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuatbrown
approved these changes
Sep 6, 2024
|
@mplorentz I think #1393 may also be caused by this. If you agree, would you add that to the "Issues covered" section of the PR description for tracking purposes? |
|
@mplorentz scratch that -- let's go the other way. I'm 99% sure #1393 is fixed by this PR so I added it to the description. If I'm wrong, you can remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
#1461
#1393
Description
This was a simple fix but an insidious bug. The code I wrote to open sockets was returning early if it found a socket that was already connected or errored.
How to test
Results should appear.