Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Search sometimes fails to show results #1393

Closed
joshuatbrown opened this issue Aug 9, 2024 · 4 comments
Closed

[Bug] Search sometimes fails to show results #1393

joshuatbrown opened this issue Aug 9, 2024 · 4 comments
Assignees

Comments

@joshuatbrown
Copy link
Contributor

joshuatbrown commented Aug 9, 2024

Describe the bug

Searching for a NIP-05 name or any text often fails.

To Reproduce

Steps to reproduce the behavior:

  1. Delete the app and reinstall
  2. Tap Discover
  3. Type a search term into the box, like "matt"
  4. Observe that no results appear (or very few)

Expected behavior

The results should show lots and lots of Matts; there are lots of them and nostr.band has them.

Screenshots or Video

RPReplay_Final1723213053.MP4

Technical info

  • OS: macOS, iOS
  • App Version: main branch, Staging 0.1.24 (399), 398, 397
  • Environment: Dev

Additional context

Rabble's report on Slack

Run this to see lots and lots of results (probably 50):

echo '{"kinds":[0],"search":"matt","limit":50}' | nak req wss://relay.nostr.band

Or just search nostr.band on the web for "matt" and see how many results there are.

It looks like local search is working, as seen in the video above. There seems to be an issue with the relay search, or displaying results from it, or something along those lines.

Sometimes the results do eventually appear, but it seems to take a very long time.

@joshuatbrown joshuatbrown self-assigned this Aug 9, 2024
@joshuatbrown joshuatbrown changed the title [Bug] Search is broken [Bug] Search sometimes fails to show results Aug 9, 2024
@joshuatbrown
Copy link
Contributor Author

This seems to have stopped happening for now, so I'm moving this to the backlog.

@setch-l
Copy link

setch-l commented Aug 26, 2024

@joshuatbrown - Is this still an issue you are seeing? Should we add something to indicate there is a slow network connection and search isn't available? As I think that was the thing that was happening. Is that detectable in the app?

@joshuatbrown
Copy link
Contributor Author

@setch-l I can't reproduce it today. I think I may have seen recently, but I don't remember for sure.

@joshuatbrown
Copy link
Contributor Author

@setch-l I believe #1466 fixed this issue, so I've moved it to UAT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants