Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various "minor" changes (4) #1435

Merged
merged 21 commits into from
Jun 20, 2023
Merged

Various "minor" changes (4) #1435

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
bfb99e1
Add schema-based validation
Hans5958 Apr 25, 2023
c38cf61
Write directly, use tqdm
Hans5958 Apr 25, 2023
f1fa8a1
Use -1 instead of 0 for new entries
Hans5958 Apr 25, 2023
a3a64f7
Rename workflow name, add caching
Hans5958 May 17, 2023
21da09f
Get image layers in parallel
Hans5958 Jun 1, 2023
dd46929
Format atlas data
Hans5958 Jun 1, 2023
e336fe4
Tidy up code
Hans5958 Jun 8, 2023
978757c
Implement per-entry patches
Hans5958 Jun 15, 2023
1c1662a
Implement per-entry patches 2
Hans5958 Jun 15, 2023
6ad26a1
Implement per-entry patches 3
Hans5958 Jun 15, 2023
a17b9df
Update CONTRIBUTING.md regarding per-entry patches and other minor fixes
Hans5958 Jun 15, 2023
da4efb6
Use index (position on Atlas data) for temporal order
Hans5958 Jun 15, 2023
4cbee4f
Implement per-entry patches 4
Hans5958 Jun 15, 2023
d3d00b9
Also validate patches on CI
Hans5958 Jun 16, 2023
6eafcef
Add information regarding per-entry patches when submitting
Hans5958 Jun 16, 2023
5dca840
Adjust contributors to not just from Reddit
Hans5958 Jun 16, 2023
5ebf030
Use _ for separator on Python file names
Hans5958 Jun 16, 2023
d626eca
Adjust JSON schema
Hans5958 Jun 16, 2023
a599b09
Revert debugging code
Hans5958 Jun 16, 2023
d47ff9d
Add contributors from Reddit (July 2022-July 2023)
Hans5958 Jun 18, 2023
414ee14
Fix behavior when merging edit patches
Hans5958 Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust JSON schema
  • Loading branch information
@Hans5958
Hans5958 committed Jun 20, 2023
commit d626eca5f4585ac47239f5a883962737f295efeb
19 changes: 14 additions & 5 deletions tools/schema/atlas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,21 @@
},
{
"type": "integer",
"minimum": 0
"minimum": 1
},
{
"type": "integer",
"minimum": -1,
"maximum": 0,
"description": "The ID of the entry. The value is a placeholder for new entries."
}
],
"description": "The ID of the entry. Usually this is the post ID of the new entry submission."
"description": "The ID of the entry. Usually, this is a number (string or number) this is the post ID of the new entry submission."
},
"name": {
"type": "string",
"description": "The short, descriptive name of the entry."
"description": "The short, descriptive name of the entry.",
"minLength": 1
},
"description": {
"type": "string",
Expand Down Expand Up @@ -55,7 +62,8 @@
"items": {
"type": "string",
"description": "The invite code of a Discord server related to the entry.",
"minItems": 1
"minItems": 1,
"minLength": 1
}
},
"wiki": {
Expand All @@ -64,7 +72,8 @@
"items": {
"type": "string",
"description": "The title of the wiki page related to the entry.",
"minItems": 1
"minItems": 1,
"minLength": 1
}
}
},
Expand Down