Various "minor" changes (4)

[Hans5958]

Sequel to #1432. This is yet another set of changes. I suggest viewing the commits tab to see (and check) the changes made. Anyone is welcome to test it, as well as giving feedback.

Some highlights:

• Add schema-based validation (7398fd3)
  This is only used on the validation workflow due to the relatively long time it take. This could be added on aformatter.py if wanted to.
• Use tqdm for progress bar, and write directly (it made it way faster) (0a23227)
• Use -1 as placeholder ID for new entries (689007a)
  0 could meant as the very first entry, index-wise, whereas -1 have a more obvious meaning of an invalid ID.
• Per-entry patches (cdd21f9)
  See Various "minor" changes (4) #1435 (comment)

[netlify]

✅ Deploy Preview for place-atlas ready!

Name	Link
🔨 Latest commit	414ee14
🔍 Latest deploy log	https://app.netlify.com/sites/place-atlas/deploys/6491d38f5f93a700084d668e
😎 Deploy Preview	https://deploy-preview-1435--place-atlas.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[Codixer]

Atlas.json conflict @Hans5958, please resolve.

[Codixer]

Meep

[Hans5958]

Wilco. I am quite busy so expect in around 24h.

[Hans5958]

An experiemental of per-entry patches has been implemented to reduce dependency on Reddit, especially on creating new entries.

Contributors now can submit patches by creating separate .json files on data/patches for each submission. For redditcrawl.py, instead generating a temporary JSON file, it will create the relevant patches instead. These patches work independently (except the cases on conflicts to which fewer manual intervention have to be done), and merging would be easy enough by using merge_out.py.

Contributors can submit patches by creating a new .json patch on data/patches, or use the included tool, create_patch.py, that assists the script user on creating a patch.

This is inspired from how changeset works on merging the information.

This gives the following advantages:

• Contributors can update the Atlas data through GitHub, and only one person have to merge it to the main Atlas data. All of this is done without dealing with the magnitude of potential conflicts that have to be solved if everyone has to change the singular, main atlas.json.
• Numerical IDs can be used again. This is either a pro or a con. I saw this as a pro, but in any way this is a better way to support both sources, next to a generating meaningless, random string.
• Reducing the dependency of Reddit. Even though we can somehow work the way through the Reddit API, some people didn't want to use Reddit as a boycott, or just for the fact that the subreddit is now closed for a while. With this, people can use multiple avenues, all without creating a overhead to the developers/staff members.

TODO

• Add info to CONTRIBUTING.md (how to create patches, how to merge, etc)
• Add info on "Create New Entry" modal
• Use the position index instead of the id for sorting by Oldest and Newest

[github-actions]

Qodana for JS

It seems all right 👌

No new problems were found according to the checks applied
💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

1. Register at Qodana Cloud and configure the action
2. Use GitHub Code Scanning with Qodana
3. Host Qodana report at GitHub Pages
4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions