Skip k8s resources that have an empty name during resource deletion #2032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r k8s versions Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
aimichelle
approved these changes
Sep 24, 2024
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Aug 6, 2025
…ixie-io#2032) Summary: Skip k8s resources that have an empty name during resource deletion Newer versions of k8s break our `px delete` cli logic (see details on pixie-io#2029). I tracked this down to the the [condition function](https://github.com/kubernetes/kubectl/blob/0315be426ca25e6554f1c9089534b62ce12254d4/pkg/cmd/wait/delete.go#L41-L43) in our ObjectDeleter. I believe the newer versions of k8s added resources that match our visitor, but don't have a resource name. From my testing, it seemed related to the `ValidatingAdmissionPolicies` or `ValidatingAdmissionPolicyBindings` resources. Relevant Issues: Closes pixie-io#2029 Type of change: /kind bugfix Test Plan: Deployed a vizier and verified that a subsequent `px delete` deleted the following * `pl` namespace * `px-operator` namespace * Cluster scoped resources: `pl-cloud-connector-role`, `pl-vizier-metadata` and `pl-node-view` cluster roles Changelog Message: Fixed an issue that caused `px delete` to fail on newer k8s clusters (1.30 and later) Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: 7a468a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Skip k8s resources that have an empty name during resource deletion
Newer versions of k8s break our
px deletecli logic (see details on #2029). I tracked this down to the the condition function in our ObjectDeleter. I believe the newer versions of k8s added resources that match our visitor, but don't have a resource name. From my testing, it seemed related to theValidatingAdmissionPoliciesorValidatingAdmissionPolicyBindingsresources.Relevant Issues: Closes #2029
Type of change: /kind bugfix
Test Plan: Deployed a vizier and verified that a subsequent
px deletedeleted the followingplnamespacepx-operatornamespacepl-cloud-connector-role,pl-vizier-metadataandpl-node-viewcluster rolesChangelog Message: Fixed an issue that caused
px deleteto fail on newer k8s clusters (1.30 and later)