Commit 7a468a4
authored
Skip k8s resources that have an empty name during resource deletion (#2032)
Summary: Skip k8s resources that have an empty name during resource
deletion
Newer versions of k8s break our `px delete` cli logic (see details on
#2029). I tracked this down to the the [condition
function](https://github.com/kubernetes/kubectl/blob/0315be426ca25e6554f1c9089534b62ce12254d4/pkg/cmd/wait/delete.go#L41-L43)
in our ObjectDeleter. I believe the newer versions of k8s added
resources that match our visitor, but don't have a resource name. From
my testing, it seemed related to the `ValidatingAdmissionPolicies` or
`ValidatingAdmissionPolicyBindings` resources.
Relevant Issues: Closes #2029
Type of change: /kind bugfix
Test Plan: Deployed a vizier and verified that a subsequent `px delete`
deleted the following
* `pl` namespace
* `px-operator` namespace
* Cluster scoped resources: `pl-cloud-connector-role`,
`pl-vizier-metadata` and `pl-node-view` cluster roles
Changelog Message: Fixed an issue that caused `px delete` to fail on
newer k8s clusters (1.30 and later)
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>1 parent 5292f58 commit 7a468a4
File tree
1 file changed
+7
-0
lines changed1 file changed
+7
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
188 | 195 | | |
189 | 196 | | |
190 | 197 | | |
| |||
0 commit comments