Use fpm binary from within dev_image_extras container for cli releases #2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
vihangm
approved these changes
Sep 10, 2024
ddelnano
deleted the
ddelnano/use-fpm-within-dev_image_extras-container
branch
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
pixie-io#2015) Summary: Use fpm binary from within dev_image_extras container for cli releases With pixie-io#2012 merged, the `dev_image_with_extras` container image now contains `fpm`. This change removes the use of podman to avoid the permission issues seen in recent cli builds. This should allow the production cli release build to succeed. Relevant Issues: Closes pixie-io#1993 Type of change: /kind bugfix Test Plan: Verified that `fpm` exists in most recent image and packaging building commands work (see testing on pixie-io#2012). Running a production cli release build is needed after this is merged to complete the testing. ``` $ ./scripts/run_docker.sh sha256:c14b06e5753d4d9c6b2ff8671843043113cdcfa3f3cb36a492a665d71dc42fad grep: /etc/bazelrc: No such file or directory Run Parameters: Build Buddy: Disabled Shell: /bin/bash + docker run --rm --hostname px-dev-docker-dev-vm.us-west1-a.c.endless-datum-422018.internal -it -v /dev/shm:/dev/shm -v /home/ddelnano:/home/ddelnano -v /var/run/docker.sock:/var/run/docker.sock -v /home/ddelnano/code/pixie-worktree:/px/src/px.dev/pixie --network=host -v /usr/local/bin/px:/bin/px px_dev_image:202409092344 /bin/bash ddelnano@px-dev-docker-dev-vm:/px/src/px.dev/pixie (ddelnano/use-fpm-within-dev_image_extras-container) $ fpm --version 1.15.1 ``` Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: 4528883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Use fpm binary from within dev_image_extras container for cli releases
With #2012 merged, the
dev_image_with_extrascontainer image now containsfpm. This change removes the use of podman to avoid the permission issues seen in recent cli builds. This should allow the production cli release build to succeed.Relevant Issues: Closes #1993
Type of change: /kind bugfix
Test Plan: Verified that
fpmexists in most recent image and packaging building commands work (see testing on #2012). Running a production cli release build is needed after this is merged to complete the testing.