Add fpm to dev container image to avoid podman in docker in GitHub actions #2012

ddelnano · 2024-09-09T03:14:14Z

Summary: Add fpm to dev container image to avoid podman in docker in GitHub actions

The production cli release build fails on these steps. The container running the job is unable to create new namespaces and runs into the following error:

+ podman run -i --rm -v /tmp/tmp.oCPtyljlYd:/src/ -v /__w/pixie/pixie:/image docker.io/cdrx/fpm-fedora:24 fpm -f -p /image/pixie-px-0.8.3.x86_64.rpm -s dir -t rpm -n pixie-px -v 0.8.3 --prefix /usr/local/bin px
time="2024-09-06T18:10:15Z" level=warning msg="\"/\" is not a shared mount, this could cause issues or missing mounts with rootless containers"
cannot clone: Operation not permitted
Error: cannot re-exec process

Rather than fix the namespace creation problem, which has been difficult to debug, this installs the necessary tools within the container. This will allow us to avoid using podman to run fpm.

This change also reverts the previous attempt at fixing this and removes genny from the container image. See this comment for more details on the genny removal.

Relevant Issues: #1993

Type of change: /kind bugfix

Test Plan: Verified that building the deb and rpm packages works from the ubuntu based dev container image and that installing the packages is successful in their respective distros

$ docker run --entrypoint bash -it docker.io/ddelnano/dev_image:202409082304
root@f65d4d86e9be:/src# fpm -f -s dir -t rpm -n pixie-px -v 0.8.3 --prefix /usr/local/bin  -p pixie-px-0.8.3.x86_64.rpm px
Created package {:path=>"pixie-px-0.8.3.x86_64.rpm"}
root@f65d4d86e9be:/src# fpm -f -s dir -t deb -n pixie-px -v 0.8.3 --prefix /usr/local/bin  -p pixie-px-0.8.3.deb  px
Created package {:path=>"pixie-px-0.8.3.deb"}

# Install the rpm package and test px in a fedora container
$ docker run --entrypoint bash -it -v $(pwd):/src/ -w /src fedora
[root@90a53608bae0 src]# rpm -i pixie-px-0.8.3.x86_64.rpm
[root@90a53608bae0 src]# px --version
Pixie CLI

Verified chef works against a Ubuntu noble VM
Ran #ci:ignore-deps and #ci:bpf-build-all-kernels build due to genny removal

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

…ixie-io#2011)" This reverts commit a4b8bc5. Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

ddelnano · 2024-09-09T03:18:35Z

tools/chef/cookbooks/px_dev/recipes/packaging.rb

+    command '/usr/bin/gem install fpm'
+    action :run


I tried to use the gem_package resource to avoid running a shell command. Unfortunately this was installing the gem within the chef ruby (confirmed with opensnoop as the build ran). Even if gem_binary specified this gem binary (/usr/bin/gem), I couldn't find a way to get it to work.

tools/chef/cookbooks/px_dev/recipes/setup.rb

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

JamesMBartlett

LGTM pending image digest updates.

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

…te docker.properties Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

ddelnano · 2024-09-10T06:06:11Z

tools/chef/cookbooks/px_dev/recipes/golang.rb

 execute 'install go binaries' do
  ENV['GOPATH'] = "/opt/px_dev/gopath"
  command %(go install github.com/golang/mock/mockgen@v1.5.0 && \
-            go install github.com/cheekybits/genny@v1.0.0 && \


Trying to install genny results in the following error:

$ go install github.com/cheekybits/genny@v1.0.0 go: finding module for package golang.org/x/tools/imports go: toolchain upgrade needed to resolve golang.org/x/tools/imports go: golang.org/x/tools@v0.25.0 requires go >= 1.22.0 (running go 1.21.0)

I wasn't able to get to the bottom of how this changed between the beginning on my PR and now or what dependency is causing this toolchain requirement.

Anyway, it appears that the last reference to genny was removed in 806ad3f. This opts to remove it instead of trying to work around this issue.

# Verify that genny is no longer used on that commit ddelnano@dev-vm:~/code/pixie-worktree ((806ad3f67...)) $ git grep -i genny go.sum:github.com/gobuffalo/genny v0.0.0-20190329151137-27723ad26ef9/go.mod h1:rWs4Z12d1Zbf19rlsn0nurr75KqhYp52EAGGxTbBhNk= go.sum:github.com/gobuffalo/genny v0.0.0-20190403191548-3ca520ef0d9e/go.mod h1:80lIj3kVJWwOrXWWMRzzdhW3DsrdjILVil/SFKBzF28= go.sum:github.com/gobuffalo/genny v0.1.0/go.mod h1:XidbUqzak3lHdS//TPu2OgiFB+51Ur5f7CSnXZ/JDvo= go.sum:github.com/gobuffalo/genny v0.1.1 h1:iQ0D6SpNXIxu52WESsD+KoQ7af2e3nCfnSBoSF/hKe0= go.sum:github.com/gobuffalo/genny v0.1.1/go.mod h1:5TExbEyY48pfunL4QSXxlDOmdsD44RRq4mVZ0Ex28Xk= Binary file go_deps.bzl matches tools/arc_addons/pixielabs/unit/ArcanistGoGenCheckerTestEngine.php: 'genny' => '/(?<=-out )(.*)(?=\.gen\.go)/', tools/chef/cookbooks/pixielabs/recipes/base.rb: github.com/cheekybits/genny@v1.0.0 \ # Go back a commit and see that XXX removed the final reference ddelnano@dev-vm:~/code/pixie-worktree ((806ad3f67...)) $ git checkout HEAD~1 Previous HEAD position was 806ad3f67 Use informers for k8s metadata watcher HEAD is now at b0d2c6c56 Add dataAccess flag to CLI ddelnano@dev-vm:~/code/pixie-worktree ((b0d2c6c56...)) $ git grep -i genny go.sum:github.com/gobuffalo/genny v0.0.0-20190329151137-27723ad26ef9/go.mod h1:rWs4Z12d1Zbf19rlsn0nurr75KqhYp52EAGGxTbBhNk= go.sum:github.com/gobuffalo/genny v0.0.0-20190403191548-3ca520ef0d9e/go.mod h1:80lIj3kVJWwOrXWWMRzzdhW3DsrdjILVil/SFKBzF28= go.sum:github.com/gobuffalo/genny v0.1.0/go.mod h1:XidbUqzak3lHdS//TPu2OgiFB+51Ur5f7CSnXZ/JDvo= go.sum:github.com/gobuffalo/genny v0.1.1 h1:iQ0D6SpNXIxu52WESsD+KoQ7af2e3nCfnSBoSF/hKe0= go.sum:github.com/gobuffalo/genny v0.1.1/go.mod h1:5TExbEyY48pfunL4QSXxlDOmdsD44RRq4mVZ0Ex28Xk= Binary file go_deps.bzl matches Binary file src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_utils.gen.go matches src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_utils.go://go:generate genny -in=k8s_metadata_utils.tmpl -out k8s_metadata_utils.gen.go gen "ReplacedResource=Pod,Service,Namespace,Endpoints,Node" src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_utils.tmpl: "github.com/cheekybits/genny/generic" tools/arc_addons/pixielabs/unit/ArcanistGoGenCheckerTestEngine.php: 'genny' => '/(?<=-out )(.*)(?=\.gen\.go)/', tools/chef/cookbooks/pixielabs/recipes/base.rb: github.com/cheekybits/genny@v1.0.0 \

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

ddelnano · 2024-09-10T06:43:54Z

tools/chef/cookbooks/px_dev_extras/recipes/packaging.rb

+  execute 'install_fpm' do
+    command '/usr/bin/gem install fpm'
+    action :run
+  end


I retested using gem_package and it installs fpm within /opt/chef/embedded as I saw during my previous test. Below is the opensnoop output filtered by fpm files and the git diff showing what I tested:

$ git diff diff --git a/tools/chef/cookbooks/px_dev_extras/recipes/packaging.rb b/tools/chef/cookbooks/px_dev_extras/recipes/packaging.rb index 7d9177935..2292ec4d6 100644 --- a/tools/chef/cookbooks/px_dev_extras/recipes/packaging.rb +++ b/tools/chef/cookbooks/px_dev_extras/recipes/packaging.rb @@ -20,8 +20,11 @@ if node.platform_family?('debian') action :upgrade end - execute 'install_fpm' do - command '/usr/bin/gem install fpm' - action :run + gem_package 'fpm' do + gem_binary '/usr/bin/gem' end + # execute 'install_fpm' do + # command '/usr/bin/gem install fpm' + # action :run + # end end $ grep fpm chef_opensnoop.txt | grep -v 'git\|php' 1759223 python3 5 0 /tmp/pip-build-tracker-dioyjfpm 1786655 chef-solo 9 0 /root/.local/share/gem/specs/index.rubygems.org%443/quick/Marshal.4.8/fpm-1.15.1.gemspec 1787105 ruby 6 0 /root/.local/share/gem/specs/index.rubygems.org%443/quick/Marshal.4.8/fpm-1.15.1.gemspec 1787105 request_set.rb* 6 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/cache/fpm-1.15.1.gem 1787105 ruby 6 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/cache/fpm-1.15.1.gem 1787105 ruby 6 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/cache/fpm-1.15.1.gem 1787105 ruby 6 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/cache/fpm-1.15.1.gem 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/CHANGELOG.rst 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/CONTRIBUTORS 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/LICENSE 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/bin/fpm 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/command.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/errors.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/namespace.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/apk.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/cpan.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/deb.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/dir.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/empty.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/freebsd.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/gem.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/npm.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/osxpkg.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/p5p.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/pacman.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/pear.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/pkgin.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/pleaserun.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/puppet.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/pyfpm/__init__.py 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/pyfpm/get_metadata.py 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/python.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/rpm.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/sh.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/snap.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/solaris.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/tar.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/virtualenv.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/package/zip.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/rake_task.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/util.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/util/tar_writer.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/lib/fpm/version.rb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/deb.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/deb/changelog.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/deb/deb.changes.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/deb/ldconfig.sh.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/deb/postinst_upgrade.sh.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/deb/postrm_upgrade.sh.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/deb/preinst_upgrade.sh.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/deb/prerm_upgrade.sh.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/osxpkg.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/p5p_metadata.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/pacman.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/pacman/INSTALL.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/pleaserun/generate-cleanup.sh 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/pleaserun/install-path.sh 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/pleaserun/install.sh 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/pleaserun/scripts/after-install.sh 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/pleaserun/scripts/before-remove.sh 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/puppet/package.pp.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/puppet/package/remove.pp.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/rpm.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/rpm/filesystem_list 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/sh.erb 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/templates/solaris.erb 1787105 ruby 6 0 /opt/chef/embedded/bin/fpm 1787105 ruby 7 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/gems/fpm-1.15.1/bin/fpm 1787105 ruby 6 0 /opt/chef/embedded/lib/ruby/gems/3.1.0/specifications/fpm-1.15.1.gemspec 1788739 rm 4 0 fpm-1.15.1 1788739 rm 4 0 fpm

#2015) Summary: Use fpm binary from within dev_image_extras container for cli releases With #2012 merged, the `dev_image_with_extras` container image now contains `fpm`. This change removes the use of podman to avoid the permission issues seen in recent cli builds. This should allow the production cli release build to succeed. Relevant Issues: Closes #1993 Type of change: /kind bugfix Test Plan: Verified that `fpm` exists in most recent image and packaging building commands work (see testing on #2012). Running a production cli release build is needed after this is merged to complete the testing. ``` $ ./scripts/run_docker.sh sha256:c14b06e5753d4d9c6b2ff8671843043113cdcfa3f3cb36a492a665d71dc42fad grep: /etc/bazelrc: No such file or directory Run Parameters: Build Buddy: Disabled Shell: /bin/bash + docker run --rm --hostname px-dev-docker-dev-vm.us-west1-a.c.endless-datum-422018.internal -it -v /dev/shm:/dev/shm -v /home/ddelnano:/home/ddelnano -v /var/run/docker.sock:/var/run/docker.sock -v /home/ddelnano/code/pixie-worktree:/px/src/px.dev/pixie --network=host -v /usr/local/bin/px:/bin/px px_dev_image:202409092344 /bin/bash ddelnano@px-dev-docker-dev-vm:/px/src/px.dev/pixie (ddelnano/use-fpm-within-dev_image_extras-container) $ fpm --version 1.15.1 ``` Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

pixie-io#2015) Summary: Use fpm binary from within dev_image_extras container for cli releases With pixie-io#2012 merged, the `dev_image_with_extras` container image now contains `fpm`. This change removes the use of podman to avoid the permission issues seen in recent cli builds. This should allow the production cli release build to succeed. Relevant Issues: Closes pixie-io#1993 Type of change: /kind bugfix Test Plan: Verified that `fpm` exists in most recent image and packaging building commands work (see testing on pixie-io#2012). Running a production cli release build is needed after this is merged to complete the testing. ``` $ ./scripts/run_docker.sh sha256:c14b06e5753d4d9c6b2ff8671843043113cdcfa3f3cb36a492a665d71dc42fad grep: /etc/bazelrc: No such file or directory Run Parameters: Build Buddy: Disabled Shell: /bin/bash + docker run --rm --hostname px-dev-docker-dev-vm.us-west1-a.c.endless-datum-422018.internal -it -v /dev/shm:/dev/shm -v /home/ddelnano:/home/ddelnano -v /var/run/docker.sock:/var/run/docker.sock -v /home/ddelnano/code/pixie-worktree:/px/src/px.dev/pixie --network=host -v /usr/local/bin/px:/bin/px px_dev_image:202409092344 /bin/bash ddelnano@px-dev-docker-dev-vm:/px/src/px.dev/pixie (ddelnano/use-fpm-within-dev_image_extras-container) $ fpm --version 1.15.1 ``` Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: 4528883

…tions (pixie-io#2012) Summary: Add fpm to dev container image to avoid podman in docker in GitHub actions The production cli release build fails on these steps. The container running the job is unable to create new namespaces and runs into the following error: ``` + podman run -i --rm -v /tmp/tmp.oCPtyljlYd:/src/ -v /__w/pixie/pixie:/image docker.io/cdrx/fpm-fedora:24 fpm -f -p /image/pixie-px-0.8.3.x86_64.rpm -s dir -t rpm -n pixie-px -v 0.8.3 --prefix /usr/local/bin px time="2024-09-06T18:10:15Z" level=warning msg="\"/\" is not a shared mount, this could cause issues or missing mounts with rootless containers" cannot clone: Operation not permitted Error: cannot re-exec process ``` Rather than fix the namespace creation problem, which has been difficult to debug, this installs the necessary tools within the container. This will allow us to avoid using podman to run `fpm`. This change also reverts the previous attempt at fixing this and removes genny from the container image. See [this comment](pixie-io#2012 (comment)) for more details on the genny removal. Relevant Issues: pixie-io#1993 Type of change: /kind bugfix Test Plan: Verified that building the deb and rpm packages works from the ubuntu based dev container image and that installing the packages is successful in their respective distros ``` $ docker run --entrypoint bash -it docker.io/ddelnano/dev_image:202409082304 root@f65d4d86e9be:/src# fpm -f -s dir -t rpm -n pixie-px -v 0.8.3 --prefix /usr/local/bin -p pixie-px-0.8.3.x86_64.rpm px Created package {:path=>"pixie-px-0.8.3.x86_64.rpm"} root@f65d4d86e9be:/src# fpm -f -s dir -t deb -n pixie-px -v 0.8.3 --prefix /usr/local/bin -p pixie-px-0.8.3.deb px Created package {:path=>"pixie-px-0.8.3.deb"} # Install the rpm package and test px in a fedora container $ docker run --entrypoint bash -it -v $(pwd):/src/ -w /src fedora [root@90a53608bae0 src]# rpm -i pixie-px-0.8.3.x86_64.rpm [root@90a53608bae0 src]# px --version Pixie CLI ``` - Verified chef works against a Ubuntu noble VM - [ ] Ran `#ci:ignore-deps` and `#ci:bpf-build-all-kernels` build due to genny removal --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: 07fff00

ddelnano added 2 commits September 7, 2024 16:21

Upgrade chef client to latest version

7ce3517

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

Install fpm in the dev docker image

c172f45

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

ddelnano requested review from a team as code owners September 9, 2024 03:14

Revert "Use privileged container for running cli build release steps (p…

e8544c9

…ixie-io#2011)" This reverts commit a4b8bc5. Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

ddelnano force-pushed the ddelnano/add-fpm-to-dev-image branch from fb2e3ec to e8544c9 Compare September 9, 2024 03:14

ddelnano commented Sep 9, 2024

View reviewed changes

JamesMBartlett reviewed Sep 9, 2024

View reviewed changes

tools/chef/cookbooks/px_dev/recipes/setup.rb Outdated Show resolved Hide resolved

Move packaging recipe to px_dev_extras

901a387

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

ddelnano force-pushed the ddelnano/add-fpm-to-dev-image branch from 7a0c3ef to 901a387 Compare September 9, 2024 22:53

JamesMBartlett approved these changes Sep 9, 2024

View reviewed changes

ddelnano added 2 commits September 10, 2024 06:01

Update base image version file

996a82a

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

Remove genny to get a successful build on current go version and upda…

d2ba8fa

…te docker.properties Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

ddelnano commented Sep 10, 2024

View reviewed changes

#ci:ignore-deps #ci:bpf-build-all-kernels

20479f7

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

ddelnano commented Sep 10, 2024

View reviewed changes

JamesMBartlett approved these changes Sep 10, 2024

View reviewed changes

ddelnano merged commit 07fff00 into pixie-io:main Sep 10, 2024

ddelnano deleted the ddelnano/add-fpm-to-dev-image branch September 10, 2024 15:40

ddelnano mentioned this pull request Sep 10, 2024

Use fpm binary from within dev_image_extras container for cli releases #2015

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add fpm to dev container image to avoid podman in docker in GitHub actions #2012

Add fpm to dev container image to avoid podman in docker in GitHub actions #2012

Uh oh!

ddelnano commented Sep 9, 2024 •

edited

Loading

Uh oh!

ddelnano Sep 9, 2024

Uh oh!

Uh oh!

JamesMBartlett left a comment

Uh oh!

ddelnano Sep 10, 2024

Uh oh!

ddelnano Sep 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add fpm to dev container image to avoid podman in docker in GitHub actions #2012

Add fpm to dev container image to avoid podman in docker in GitHub actions #2012

Uh oh!

Conversation

ddelnano commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ddelnano Sep 9, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JamesMBartlett left a comment

Choose a reason for hiding this comment

Uh oh!

ddelnano Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

ddelnano Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ddelnano commented Sep 9, 2024 •

edited

Loading