Use maintained gon fork to address Apple signing deprecation #1997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelnano
commented
Sep 4, 2024
ddelnano
added a commit
that referenced
this pull request
Sep 4, 2024
… to parse (#2005) Summary: Fix bug where cli manifests with `AT_DARWIN_ARM64` ArtifactTypes fail to parse This was an error I ran into when testing #1997. You can see the failure output from the [following build](https://github.com/pixie-io/pixie/actions/runs/10705210930/job/29681122220?pr=1997) (also copied below). ``` INFO: Running command line: bazel-bin/src/utils/artifacts/manifest_updater/manifest_updater_/manifest_updater '--manifest_updates=/__w/pixie/pixie/manifest_updates.json' '--manifest_path=/__w/pixie/pixie/gh-pages/artifacts/manifest.json' time="2024-09-04T16:17:53Z" level=fatal msg="failed to read manifest updates" error="unknown value \"AT_DARWIN_ARM64\" for enum px.versions.ArtifactType" ``` Relevant Issues: #1993 Type of change: /kind bugfix Test Plan: Built the manifest_updater binary and verified it no longer fails with a parse error ``` $ ./manifest_updater --manifest_updates manifest_updates.json --manifest_path=manifest.json $ ``` --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
…ectory during macos signed artifact push Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
force-pushed
the
ddelnano/fix-cli-builds-with-maintained-gon-fork
branch
from
4e374a3 to
ff89e27
Compare
Member
Author
|
@pixie-io/core-maintainers this is ready for review now that I've gotten a successful build. |
aimichelle
reviewed
Sep 5, 2024
Member
aimichelle
left a comment
aimichelle
left a comment
There was a problem hiding this comment.
We were just using a personal Apple developer account to do signing before. Thanks to Cosmic for offering to provide the signed macOS binaries!
aimichelle
approved these changes
Sep 5, 2024
vihangm
approved these changes
Sep 5, 2024
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
deleted the
ddelnano/fix-cli-builds-with-maintained-gon-fork
branch
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
… to parse (pixie-io#2005) Summary: Fix bug where cli manifests with `AT_DARWIN_ARM64` ArtifactTypes fail to parse This was an error I ran into when testing pixie-io#1997. You can see the failure output from the [following build](https://github.com/pixie-io/pixie/actions/runs/10705210930/job/29681122220?pr=1997) (also copied below). ``` INFO: Running command line: bazel-bin/src/utils/artifacts/manifest_updater/manifest_updater_/manifest_updater '--manifest_updates=/__w/pixie/pixie/manifest_updates.json' '--manifest_path=/__w/pixie/pixie/gh-pages/artifacts/manifest.json' time="2024-09-04T16:17:53Z" level=fatal msg="failed to read manifest updates" error="unknown value \"AT_DARWIN_ARM64\" for enum px.versions.ArtifactType" ``` Relevant Issues: pixie-io#1993 Type of change: /kind bugfix Test Plan: Built the manifest_updater binary and verified it no longer fails with a parse error ``` $ ./manifest_updater --manifest_updates manifest_updates.json --manifest_path=manifest.json $ ``` --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: afffb8e
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
…o#1997) Summary: Use maintained gon fork to address Apple signing deprecation This is a continuation of pixie-io#1994. Rather than using the macos tools directly, we can continue using gon by switching to the maintained fork ([github.com/Bearer/gon](https://github.com/Bearer/gon)) Relevant Issues: Closes pixie-io#1993 Type of change: /kind bugfix Test Plan: cli-release GitHub workflow [succeeds](https://github.com/pixie-io/pixie/actions/runs/10724342153/job/29740236170) when built from this branch Changelog Message: Fix macos signing for px cli releases --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: 3a76a27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Use maintained gon fork to address Apple signing deprecation
This is a continuation of #1994. Rather than using the macos tools directly, we can continue using gon by switching to the maintained fork (github.com/Bearer/gon)
Relevant Issues: Closes #1993
Type of change: /kind bugfix
Test Plan: cli-release GitHub workflow succeeds when built from this branch
Changelog Message: Fix macos signing for px cli releases