Replace gon macos signing with notarytool #1994
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelnano
force-pushed
the
ddelnano/replace-gon-with-notarytool
branch
from
43591bd to
7fcc761
Compare
ddelnano
commented
Aug 26, 2024
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
force-pushed
the
ddelnano/replace-gon-with-notarytool
branch
from
7fcc761 to
82a7944
Compare
ddelnano
commented
Aug 26, 2024
| gon ci/gon.hcl | ||
| export TEAM_ID="SZCNTABEXY" | ||
| export APP_IDENTITY="Developer ID Application: Pixie Labs Inc. (${TEAM_ID})" | ||
| codesign -f -v --timestamp --options runtime -s "${APP_IDENTITY}" cli_darwin_universal cli_darwin_arm64 cli_darwin_amd64 |
Member
Author
There was a problem hiding this comment.
This was modeled off how gon runs codesign (source)
…nt variables Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
…ommand Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Member
|
I'm wondering if we should switch to https://github.com/Bearer/gon which seems to be a maintained fork of the original and switches over to |
Member
Author
|
Using that fork is fine with me. I'll update this PR to take that approach. Unfortunately the developer account we use has expired and is blocking finishing off the testing of this. |
Member
Author
|
Closing since we will be proceeding with #1997. |
ddelnano
added a commit
that referenced
this pull request
Sep 5, 2024
Summary: Use maintained gon fork to address Apple signing deprecation This is a continuation of #1994. Rather than using the macos tools directly, we can continue using gon by switching to the maintained fork ([github.com/Bearer/gon](https://github.com/Bearer/gon)) Relevant Issues: Closes #1993 Type of change: /kind bugfix Test Plan: cli-release GitHub workflow [succeeds](https://github.com/pixie-io/pixie/actions/runs/10724342153/job/29740236170) when built from this branch Changelog Message: Fix macos signing for px cli releases --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
…o#1997) Summary: Use maintained gon fork to address Apple signing deprecation This is a continuation of pixie-io#1994. Rather than using the macos tools directly, we can continue using gon by switching to the maintained fork ([github.com/Bearer/gon](https://github.com/Bearer/gon)) Relevant Issues: Closes pixie-io#1993 Type of change: /kind bugfix Test Plan: cli-release GitHub workflow [succeeds](https://github.com/pixie-io/pixie/actions/runs/10724342153/job/29740236170) when built from this branch Changelog Message: Fix macos signing for px cli releases --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: 3a76a27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Replace gon macos signing with notarytool
Relevant Issues: #1993
Type of change: /kind bugfix
Test Plan: Read a few examples of migrated cli invocations, however, seeing a successful cli release is necessary to fully test this