Skip to content

[stirling] Fix netty_tls_trace_bpf_test.cc mux protocol tracing option. #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zasgar merged 3 commits into from
Aug 29, 2023
Merged

[stirling] Fix netty_tls_trace_bpf_test.cc mux protocol tracing option. #1690

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2274304
[stirling] Fix netty TLS trace BPF test.
Aug 29, 2023
7d26c84
Tidy.
Aug 29, 2023
3342b6e
Tidy.
Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 17 additions & 18 deletions src/stirling/source_connectors/socket_tracer/netty_tls_trace_bpf_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,28 +50,27 @@ using ::testing::UnorderedElementsAre;

class ThriftMuxServerContainerWrapper : public ::px::stirling::testing::ThriftMuxServerContainer {};

// The Init() function is used to set flags for the entire test.
// We can't do this in the MuxTraceTest constructor, because it will be too late
// (SocketTraceBPFTestFixture will already have been constructed).
bool Init() {
// Make sure Mux tracing is enabled.
FLAGS_stirling_enable_mux_tracing = true;

// We turn off CQL and NATS tracing to give some BPF instructions back for Mux.
// This is required for older kernels with only 4096 BPF instructions.
FLAGS_stirling_enable_cass_tracing = false;
FLAGS_stirling_enable_nats_tracing = false;

// Enable the raw fptr fallback for determining ssl lib version.
FLAGS_openssl_raw_fptrs_enabled = true;
return true;
namespace {
constexpr bool kClientSideTracing = false;
}

bool kInit = Init();

template <typename TServerContainer>
class BaseOpenSSLTraceTest : public SocketTraceBPFTestFixture</* TClientSideTracing */ false> {
class BaseOpenSSLTraceTest : public SocketTraceBPFTestFixture<kClientSideTracing> {
protected:
void SetUp() override {
PX_SET_FOR_SCOPE(FLAGS_stirling_enable_mux_tracing, true);

// We turn off CQL and NATS tracing to give some BPF instructions back for Mux.
// This is required for older kernels with only 4096 BPF instructions.
PX_SET_FOR_SCOPE(FLAGS_stirling_enable_cass_tracing, false);
PX_SET_FOR_SCOPE(FLAGS_stirling_enable_nats_tracing, false);

// Enable the raw fptr fallback for determining ssl lib version.
PX_SET_FOR_SCOPE(FLAGS_openssl_raw_fptrs_enabled, true);

SocketTraceBPFTestFixture<kClientSideTracing>::SetUp();
}

BaseOpenSSLTraceTest() {
// Run the nginx HTTPS server.
// The container runner will make sure it is in the ready state before unblocking.
Expand Down