[stirling] Fix netty_tls_trace_bpf_test.cc mux protocol tracing option.
#1690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
etep
changed the title
netty_tls_trace_bpf_test.cc mux protocol tracing option.
benkilimnik
approved these changes
Aug 29, 2023
ddelnano
approved these changes
Aug 29, 2023
zasgar
approved these changes
Aug 29, 2023
benkilimnik
pushed a commit
to benkilimnik/pixie-privy
that referenced
this pull request
Sep 5, 2023
…ion. (pixie-io#1690) Summary: To prevent older kernels from complaining about eBPF instruction count, mux protocol tracing is only enabled for "newer" kernels. In our test case, we want to enable mux tracing. We fix test `netty_tls_trace_bpf_test.cc` by enabling mux protocol tracing using the test `SetUp` method (and we simultaneously disable a few other protocols to save on eBPF instruction count). Previously, we used an init function, but that was rendered ineffective after we switched our flags from command line args. to env. args. Type of change: /kind bug fix Test Plan: Existing tests. Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: To prevent older kernels from complaining about eBPF instruction count, mux protocol tracing is only enabled for "newer" kernels. In our test case, we want to enable mux tracing. We fix test
netty_tls_trace_bpf_test.ccby enabling mux protocol tracing using the testSetUpmethod (and we simultaneously disable a few other protocols to save on eBPF instruction count). Previously, we used an init function, but that was rendered ineffective after we switched our flags from command line args. to env. args.Type of change: /kind bug fix
Test Plan: Existing tests.