Use [[likely]] and [[unlikely]] in c++20 mode #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling in the c++20 mode, use the standard [[likely]] and [[unlikely]] instead of GNU built-ins. It enables these directives on other platforms. All uses of our macros had to be edited to remove the outer parentheses. Implements: #570 Signed-off-by: Michal Siedlaczek <michal@siedlaczek.me>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #576 +/- ##
=======================================
Coverage 93.28% 93.28%
=======================================
Files 90 90
Lines 4454 4454
=======================================
Hits 4155 4155
Misses 299 299 ☔ View full report in Codecov by Sentry. |
JMMackenzie
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling in the c++20 mode, use the standard [[likely]] and [[unlikely]] instead of GNU built-ins. It enables these directives on other platforms.
All uses of our macros had to be edited to remove the outer parentheses.
Implements: #570