Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of total docking pads at station to lobby #4773

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

impaktor
Copy link
Member

I've been playing with the lobby (motivated by comments in other PR), trying to see how much of that code I can muster. So in experimenting, I added one more info sentence.

(I imagine these Lobby-sentences, sort of how the pilot annonuces the weather when you land at a new airport)

I'm doing this as WIP, because maybe wording can be better (suggestions?), or I find other stuff to add to it.

Possibly we'd also like to add information about how many ships are currently
docked, as this only shows the total capacity.

2020-01-18-102555_1600x900_scrot
2020-01-18-102616_1600x900_scrot

Possibly we'd also like to add information about how many ships are currently
docked, as this only shows the total capacity.
@WKFO
Copy link
Contributor

WKFO commented Jan 19, 2020

Didn't look at the code, but if possible, we could also separate medium and small docking pads, like "...total of 4 medium and 12 small docking pads." or something.

@impaktor
Copy link
Member Author

Yeah, that would be better, but that information isn't as easily accessible. @fluffyfreak would know for sure where to get that info. Not sure it's even exposed on Lua side, but would have to do some digging.

(I'm also thinking police station would say how many police ships there are, and how many are docked).

@sturnclaw
Copy link
Member

I'm not 100% sure the game even makes the distinction between pad sizes. I might be wrong, but AFAIK the landing and station code doesn't really care, it just knows "pad" and "not pad".

@fluffyfreak
Copy link
Contributor

Internally the pad sizes matter, you can't be allocated a pad smaller than your ship for example. I don't know if that's exposed anywhere though.

@impaktor impaktor marked this pull request as ready for review February 11, 2020 17:30
@impaktor impaktor merged commit 6ebf3e2 into pioneerspacesim:master Feb 14, 2020
@impaktor impaktor deleted the add_info_numdocks branch February 14, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants