New mission: Find person #4746

robothauler · 2019-11-23T17:12:43Z

The player has to find a person or a person with a ship and hand over a message. Which means hopping from station to station. Then return, or transport the person back. The ideas are taken from https://forum.pioneerspacesim.net/viewtopic.php?f=3&t=487. I tried to add some surprises like pirates firing missiles or mercenaries who try to intercept if close to the planet.

Unfortunately, merging this will cause two issues.

~~The missile launch is not detected. No warning.~~ ~~No police action.~~
Close to a station, the mercenary can fire what he can. But the player is immediately attacked by the police.

While 2. can be solved later. ~~It would be great if someone can take care of 1. e.g. play a warning sound and trigger an event so that other modules can take action.~~

impaktor · 2019-11-23T17:41:35Z

Hey! I think I have a very old branch, where I have a lot of "mysterious" messages that can be delivered. Could that be incorporated in this? (I have not tried this PR or looked at your code yet).

Look at MESSAGE_1-MESSAGE_70 here: https://github.com/impaktor/pioneer/blob/deliverMessage/data/lang/module-delivermessage/en.json#L102

EDIT: the reason I never opened a PR on that branch is because the code is just a copy-pase of DeliverPackage, which wouldn't really add any novel game play.

mike-f1 · 2019-11-24T11:04:21Z

The missile launch is not detected. No warning. No police action.

You can modify:

pioneer/src/Ship.cpp

Line 1064 in 0c66156

void Ship::UpdateAlertState()

In order to obtain a "Warning" for missile launch, you should change the "for" to handle Missile...

Optionally, you can add a method to get the target of Missile and narrow the alert state propagation.

robothauler · 2019-11-25T10:55:02Z

@impaktor, the message is more a file or a document or simply "If you want to be alive, jump into my ship".

@mike-f1, thank you for the hint.

mike-f1 · 2019-12-03T14:17:55Z

@mike-f1, thank you for the hint.

You're welcome :)

If I may, why not to "push" a different string instead of "ship-firing" (in LuaPlayer.cpp)?

And another thing I would note and could be done here or in a different PR:
wouldn't it be easy to move the code for 'ship-equipping' in Ship.lua? ...IIRC there are a lot of code spreads along all modules which do the same exact thing. Just pick one ;)

Close to a station, the mercenary can fire what he can. But the player is immediately attacked by the police.

Found (and probably a change here will also close #4713) :

pioneer/data/modules/CrimeTracking/CrimeTracking.lua

Line 29 in d2ab921

station:LaunchPolice(Game.player)

...which have an obious fix ;) Though I can't beat it will works well.

It's still quite limited even if you let any ship as a target: for example only a single mercenary/pirate will be prosecuted; if you fire back even you will be prosecuted... But at least you can obtain a more realistic behaviour.

impaktor · 2019-12-15T16:50:40Z

Just an update from my side: I intend to review this (read code, and test play a mission), I'll have time over Christmas, which for me starts now on Tuesday (I had some vacation saved up), so please nag on me if I'm inactive.

impaktor · 2019-12-21T09:12:15Z

I've just done a fist quick glance, and I note:

There's no BBS-icon. That's perfectly fine in my book, and can be added later (E.g. magnifying glass over a person?), maybe @nozmajner has thoughts / want to know.
Not all mission headlines (specifically ADTEXT_1 & ADTEXT_2) start with uppercase on BBS. E.g. "SEARCH MISSION" does, but "Find person in X system" doesn't.
Technically, I don't think we have this as a formal rule, but (almost?) all adverts follow it, so I'd recommend this module to do the same.

I'll get back with more feedback.

bszlrd · 2019-12-21T10:13:37Z

I'll make an icon, not sure when I can get to it though.

impaktor

I've made some comments, mainly suggestions on the en.json file. I see you have many of the strings doubled, to have a female and male gendered sentence. I don't think any other module does that, but I guess that helps with translation for some languages. I've not repeated my comments for both male/female versions of sentences, so I'll leave that up to you.

I have yet to go through the Lua file. I'm curious how a player can find an NPC in a "bar" or "shipyard", or just "anywhere in System X", that the language file seems to suggest should be possible.

data/lang/module-findperson/en.json

robothauler · 2019-12-26T19:51:57Z

I have yet to go through the Lua file. I'm curious how a player can find an NPC in a "bar" or "shipyard", or just "anywhere in System X", that the language file seems to suggest should be possible.

Please do not expect too much! You need a bit of imagination here. ;-)

impaktor

I have yet to go through the actual Lua file, but I've done the en.json / language strings, and glanced over the C++ commit. Perhaps @Web-eWorks, or other team-C++ people could have a quick gander at the commit that implements an Alert Missile Warning state in Ship.cpp:
dc8b031

(I'll get cracking on the Lua file now)

data/lang/core/en.json

src/Ship.cpp

sturnclaw · 2019-12-29T18:42:44Z

The C++ code looks good to me so far, fairly standard and in keeping with the rest of the code. You'll need to make sure it conforms with our existing style guides as best as possible, but I don't have any objections.

...That doesn't mean I like how the alert system is implemented in general, but that's a complaint for another time, when I have the energy to rip the whole thing out.

impaktor · 2020-01-01T18:24:23Z

intro

Am I understanding it correctly, that the format for this mission type is:

fly to system X
visit every spaceport in system X until mission becomes halfdone (i.e.
player happens to visit the station where the missing person is)
they fly back to mission contractor?

(plus chance of being attacked/intercepted)

feedback

If So, it's quite similar to all our other delivery missions, except the player now has to figure out the correct starport?

I tried two missions, one to Sol, and another to some other densely populated system, so I really didn't feel like visiting 10-20 stations, so I gave up (sorry).

Due to the amount of in-system travel, it might be worth only assigning missions to single star systems, and possibly have the number of stations in it add to the deadline in some way (square root of the number?), or filter out the worst offenders (although that wouldn't be stable if we change our universe to be more densely packed in the future). Maybe only use the N most sparse system within some radius of the BBS?

Anyway, these are just some random thoughts/suggestions, you decide if you want to act on them, I'm just pointing out what struck me when I played it.

The best would be if any of our players could test this out.

(By the way, the new Missile Alert state isn't needed for this PR, right? So anyone wanting to test can just download the lua + json file, and not needing any recompile?)

Some more suggested changes:

"Is there a risk" --> "Is there any risk"
Also, the copyrright for the new files you've added (except *.json files): 2019 -> 2020

robothauler · 2020-01-04T13:45:54Z

I increased the probability of the tipster. After a few stations the player should now know where to go.

robothauler · 2020-01-04T13:53:05Z

(By the way, the new Missile Alert state isn't needed for this PR, right? So anyone wanting to test can just download the lua + json file, and not needing any recompile?)

Yes, that should work.

impaktor · 2020-01-05T15:33:02Z

I'll give it another play through.

By the way, something that I thought of, you have a flavour that's very specific, a drone flying into someone's apartment, it just struck me that the more specific a description is, the stranger it will look to see that one twice, or multiple times.

I.e. "Hi, I'm X, I want transport to Y" works repeatedly, but "Hi find Y because a drone flew into their apartment" is less general. But perhaps in the future there's serious drone hazard?

Anyway, it could be more general by being un-specific about what caused the damaged. or even more general to say property, rather than apartment, but that might be a little flavour less. Anyway, that's just what came into my mind when I read it.

robothauler · 2020-01-08T19:10:12Z

But perhaps in the future there's serious drone hazard?

If that's not worth a headline in a BBS newspaper ...

impaktor · 2020-01-11T11:55:00Z

OK, I've tested it now.

I get tip of which station I should go to every time (3 out of 3) times I land. Maybe fluke? I haven't looked at the code, but I imagine it could be some cumulative probability, i.e. after you landed on 2-3 stations the probability of getting a tip next time you land is close to 100%

Just a thought.

What probably should be fixed, is that I get tip for station even if I'm not in the mission system. E.g. if I land on a base in Tau Ceti, I get "I heard Jimmy Hoffa is in London". I imagine such information of which starbase they're on to only be "local", in the mission system?

Gliese852 · 2020-01-13T20:33:27Z

Is it possible to add options to the other items on the bulletin board with the question of the person you are looking for?

impaktor · 2020-01-16T09:12:00Z

OK, I really hate it when I do work, get a little feedback, fix it, thinking I'm done, then get some more nitpick feedback, fix it thinking, "OK, now I'm done", and loop continues iterating. Thus I don't want to be like that here. Also, I've seen many PRs die because people suggest to "make it more general", or is some other way expand the scope beyond what the author contributed.

Thus, I apologize for doing all of the above now, but I just need to shoot off these ideas:

Is it possible to add options to the other items on the bulletin board with the question of the person you are looking for?

It's kind of hackish solution, but maybe less so than the current one, i.e. land and you "auto detect" people's presence.

Such a button would do best to e.g. engage the lobby-staff in a conversation, and get a box:

  +----------------------+
  |  Have anyone seen:   |
  |----------------------+
  | L. Skywalker         |
  | J. Hoffa             |
  | Lindbergh Jr.        |
  |                      |
  |                      |
  +------------------+---+
  | +----------+         |
  | |  ASK     |         |
  | +----------+         |
  +----------------------+

They might answer something like:

Yes, they're here
No, but perhaps another station knows
No, but I've heard / computer system said they're in station A in this system
if lawlessness >> 0 then: For x credits I can get the information you're looking for

(If we could engage the lobby in conversation, then the advice/rumor module could move to that as well.)

Anyway, my main objection with this module is it's too similar to delivery package / taxi missions / cargo mission, i.e. 1. go to mission system, 2. land on stations until you notice a message on your comms, 3. go back to client's system/station.

Although pioneer is more limited than I'd like, in what is possible to do, there are still some interesting modules left to be written:

Search & rescue: interesting because let's player see NPC ships up close
Cargo mission: interesting because uses custom cargo functionality, but suffers from the dull station-traveling
Cargo-scoop-mission (as suggested by @robothauler): Pick up debris after space battle, or illegal cargo pick up, interesting due to use of cargo scoop
Exploration: interesting because player gets to fly long distances, to discover new systems and set a system as explored. I know we've had a long discussion on the dev-forum, but I think one could have a stab at it with simple as possible: get payed for number of systems explored, and bodies discovered, or similar.
Scout: interesting because it forces player to fly close to land, showing off terrain generator (I have a branch on this, just a UI progress-bar missing, I think)
Find missing person: could be interesting in adding immersion to the universe in that the NPCs are more "real" they persist across jumps, they are known to other NPCs, and can be missed.

I realize what I'm suggesting above regarding lobby is way more work, but it would really make this "unique", I think, but, yeah, main work is of course figuring out how to bend that code to this will.

I guess other's have to give feedback on how much work that might be. Logs say @vakhoir is the main Lobby-hacker.

Anyway, there is that bug I pointed out in my previous post that needs fixing on this PR.

EDIT Updated 2025-02-22 after fluffy's comment below reminded me this PR is still open. Checked off many of the boxes above of mission modules we now have in the game.

robothauler · 2020-01-18T16:23:56Z

Is it possible to add options to the other items on the bulletin board with the question of the person you are looking for?

It's kind of hackish solution, but maybe less so than the current one, i.e. land and you "auto detect" people's presence.

Such a button would do best to e.g. engage the lobby-staff in a conversation, and get a box:
...

Or add a new tab view for a very simple bar e.g. only clickable faces

impaktor · 2020-01-18T19:19:17Z

@robothauler This is what I've been doing this morning:

I need to replace that list with clickable names, that opens an interaction dialogue. Not sure I have the skill to do that, but I'll see how deep into pigui territory I can get. But my thinking was to move advice module, and illegal goods trader into the bar, plus assassination missions, which you get by talking to the people there, a bar would consist of random NPC visitors + permanent "fixers", and shady "Tony Soprano"-characters.

Downside with using a bar for finding missing people, is then they're always in the bar, and never found through the BBS. In the original Frontier the BBS adverts weren't modularised like we have it, so their "find missing person" mission worked across all characters in the station, which I guess is the "propper way" (not sure if we can/should do that even in the long run).

Today I realized it might make "the most" sense to have the previously described ask-lobby-for-missing-person in the police tab instead? That's not even in pigui, so even more work...

Gliese852 · 2020-01-18T19:51:44Z

It seems to me not very difficult to organize a dialogue with any character in the game. with the lobby, the police, the service man, the pilot of another ship. When a certain button is pressed, a communication window may appear, and an event is generated with the parameters of this character, which any script can catch, and add its own dialogue branches to this window. Maybe I'm too optimistic.

Gliese852 · 2020-01-18T20:01:24Z

And I would like to clarify about the bar, does the player leave the ship at all? I ask because the entire menu of the station is accessible through the "comms" button.

fluffyfreak · 2025-02-15T13:57:59Z

Instead of asking people to clear bars and add functionality to other areas before allowing new features in, I think it's better to take what is presented with it's current scope. Utilising the persistent character work might be nice, but what really happens is that a new features gets abandoned for 5 years and eventually dropped.

impaktor · 2025-02-22T09:42:56Z

data/modules/FindPerson/FindPerson.lua

@@ -0,0 +1,606 @@
+-- Copyright © 2008-2020 Pioneer Developers. See AUTHORS.txt for details


impaktor · 2025-02-22T10:00:13Z

Update 5 years later

OK, I've gone through the above discussions to remember what this was about (I've fixed broken link to forum, and updated one of my key posts above).

This PR was stalled in part because we were in the process of moving BBS (and police) screens to pigui, which this PR then needs to take into consideration.

@robothauler I see you've pushed updated code, I'm very happy to see you're still with us and motivated (enough) to keep this PR alive. Pardon the 5 years in limbo. I see you've put it as a draft release (also new github feature that did not exist 5 years ago). What is the minimum work needed to move this PR to 'active'(non-draft) state?

Where do we find missing persons?

If I'm to think out loud how we ideally like things to work (not saying poor @robothauler should implement this). Above several possibilities were suggested:

Missing persons are always to be found in a bar (to-be-implemented tab with list of people in the bar) of some space station. I started on this in NewUI, but should be easier in pigui.
Police tab has a button: "find missing person" where a you can select person you're looking for (if looking for several) and see if police know their whereabouts.
As in Frontier: missing person are persistent and BBS adverts pull from some queue of persistent characters when creating new missions? I imagine that would be a way to have BBS adverts share information.
Just like how BBS dialogue boxes add some additional buttons from pigui library ("set as destination", "close", I think) one could have a button "I'm looking for someone", (conditional on having accepted a missing person mission?). Might open a table of people you're looking for.
@Gliese852 suggested:

It seems to me not very difficult to organize a dialogue with any character in the game. with the lobby, the police, the service man, the pilot of another ship. When a certain button is pressed, a communication window may appear, and an event is generated with the parameters of this character, which any script can catch, and add its own dialogue branches to this window. Maybe I'm too optimistic.

That's the summary of above discussions.

@robothauler is this in playable testable state?

robothauler · 2025-02-22T10:41:42Z

@robothauler is this in playable testable state?

I'm just trying to find out what works and what doesn't.

robothauler · 2025-03-07T10:29:21Z

It is now in a playable condition again.

impaktor

I've tried one mission, was of type visit some stations, then get tip of where to go, go there, then return. Nice.

Have some additional thoughts:

LSP

I recommend you use a LSP (language server protocol) in your editor (they all support it nowadays, unless you're in Notepad) e.g. on Arch Linux I use lua-language-server upstream source it shows various issues in the code (and gives you variable auto-complete, bells and whistles)

debug info

This is just a suggestion, but for your own sanity (and who ever else will be working on this code), displaying values of internal active mission varialbes to the debug window (Ctrl+i) helps a lot with future development, testing, and debugging, and will pay off in the long run. Look at NewsEventCommodity module code and how it's usied in the debug window (Ctrl+i, click the "i"-icon).

(I know sturnclaw has mentioned grouping mission module debug tabs in some nifty way in the future, but for now it can play nice with the other tabs in the debug window.)

other thoughts

I note there are several different versions of this mission, i.e. quite diverse set of missions, that each will have to be tested. some look to be taxi-missions requiring empty cabin. I've not tested those. (spawning these different types of missions on the BBS could be implemented in the debug window).

impaktor · 2025-03-09T09:09:57Z

data/modules/FindPerson/FindPerson.lua

+local Character = require 'Character'
+local NameGen = require 'NameGen'
+local Equipment = require 'Equipment'
+local ShipDef = require 'ShipDef'


L18 L17, L20 are unused & can be dropped.

impaktor · 2025-03-09T09:12:28Z

data/modules/FindPerson/FindPerson.lua

+
+local onCreateBB = function (station)
+	local num = Engine.rand:Integer(0, math.ceil(Game.system.population) / 2)
+	for i = 1, num do


My mind is foggy, from not coding in a while, but in Python (and according to my lua lint checker) unused variables should be named _, rather than i here.

impaktor · 2025-03-09T09:14:32Z

data/modules/FindPerson/FindPerson.lua

+local onShipFiring = function (ship)
+	if ship:IsPlayer() then return end
+
+	for ref, mission in pairs(missions) do


if we're to do the _ thingy, then there are a bunch of for loops with ref that are unused from this point forward. Personally, I don't mind as it might be useful for future re-visits to re-write the code.

impaktor · 2025-03-09T09:17:44Z

data/lang/module-findperson/en.json

+  },
+  "INTROTEXT_TAXI_FEMALE_1": {
+    "description": "",
+    "message": "Hi. I'm {client}. I'm looking for a relative in the {system} ({sectorx}, {sectory}, {sectorz}) system. Her name is {wanted}. Time is very crucial because her mother is seriously ill. Please find her and bring her back to {domicile}. I pay you {cash}."


Thought: it's less weird to see repeated entries on the BBS of a more generic statement than a specific, here the "sick mother" could be "medical emergency in the family", or something similar

impaktor · 2025-03-09T09:20:56Z

data/lang/module-findperson/en.json

+  },
+  "INTROTEXT_DELIVER_MESSAGE_FEMALE_1": {
+    "description": "",
+    "message": "Hi, my name is {client}. I'm looking for my stepsister {wanted}. She left the family in anger a few years ago. A friend of mine has seen her recently in the {system} ({sectorx}, {sectory}, {sectorz}) system. So I think the time has come for a reconciliation. I pay you {cash} if you can deliver a message to her and return to {domicile} with an answer. Please do it! Will you?"


So I think the time has come for a reconciliation

Nitpick: The "So" word makes it sound like reconciliation follows from someone having seen her/him. I don't know what other's think, but that doesn't follow in my mind. Perhaps "I'd like to see if time (or he/she) is ripe (ready) for reconciliation",

impaktor · 2025-03-09T09:23:36Z

data/lang/module-findperson/en.json

+    "description": "",
+    "message": "I don't know. That's up to you!"
+  },
+  "HOW_TO_TAXI_MALE": {


This flavor response (male/female) has me split. On one hand, I think there should be a hint. Or maybe there is a point in having the player have to experiment (what say you @bszlrd ?). Should there be hand-holding, or throwing out the player in the deep end of the pool? But I'm currently reading the source to figure out what I'm to do. :P

am I to look for a ship in the system, or land at a station and hope someone contacts me, or check crew contracts lists, names in BBS adverts?

Perhaps have "maybe someone in the system has information?" as hint?

impaktor · 2025-03-09T09:25:51Z

data/modules/FindPerson/FindPerson.lua

+local max_mission_dist = 20
+local typical_reward = 50
+
+local flavours = {


Thought for @bszlrd this module has many flavours, perhaps different icons for some/all? of them?

local flavours = { { id = "DELIVER_MESSAGE", ship = false, taxi = false, company = false, max_risk = 0.1 }, { id = "TRAITOR", ship = false, taxi = false, company = true, max_risk = 1 }, { id = "PRIVATEER", ship = true, taxi = false, company = false, max_risk = 0.75 }, { id = "DELIVER_DOCUMENT", ship = true, taxi = false, company = true, max_risk = 1 }, { id = "TAXI", ship = false, taxi = true, company = false, max_risk = 0.1 }, { id = "EVACUATION", ship = false, taxi = true, company = true, max_risk = 1 }, }

impaktor · 2025-03-09T10:09:07Z

data/lang/module-findperson/en.json

+    "description": "",
+    "message": "System:"
+  },
+  "TIP_FEMALE_1": {


Some of these tips are quite similar, but never mind. I suggest at least one starts with "I heard you were looking for {name}, I've seen them in X"

impaktor · 2025-03-09T10:39:45Z

data/modules/FindPerson/FindPerson.lua

+					if station.path ~= mission.visited[#mission.visited] then
+						table.insert(mission.visited, station.path)
+					end
+					if #mission.visited > Engine.rand:Number(4) then


This looks strange to me. So the strategy is to increase probability of player finding the person based on number of stations they've landed on (good), but there's no mechanism for how many stations there are in the system to land on?

It should not be possible to run out of stations, i.e. when landed on 100% of the stations (or lower), then the probability of finding the person should be 100%. Here, if the system has fewer than 4 stations, they might not be able to find the person?

I have a vague memory of using Bebbington's algorithm [A.C. Bebbington, Appl. Stat. vol. 24, p. 136 (1975).] somewhere in the pioneer code before, it's not exactly applicable in your case, but for inspiration, it sates how to place n particles on M lattice sites with equal probability:

Start with the first lattice site. Choose to occupy that lattice site with probability n/M. If the lattice site was chosen to be occupied decrease n by 1, (n → n − 1). Reduce M by one (M → M − 1), and proceed to the next lattice site and occupy with probability n/M etc. Note that n and M changes during the loop over lattice sites.

Going through all lattice sites, 1, ..., M, using the scheme above results in exactly n lattice sites being chosen (with equal probability).

Now, in your case, n might be people to find in the system (n=1 always), and M be the number of stations, but perhaps replaced with a capped version, M_cap <= M if M is too large (like in Sol).

What I've written might be goobely-gook, but I had it easily accessible so that's where my brain went.

This is the probability of the tipster! The wanted person always sits in the selected station.
By the way. How about moving the tipster to the BB and letting the player decide whether he wants to pay for the information?

This is the probability of the tipster!

Ah, OK.

By the way. How about moving the tipster to the BB and letting the player decide whether he wants to pay for the information?

Actually, I think @bszlrd (or someone else?) suggested this a while back on IRC. I think, long term, the player should do some action when they land to do the "search", like looking up station listing/logs, asking someone, pressing a button that issues a request for finding person (I imagine police would know, but I think @sturnclaw was not sold on that). Making a BBS advert could be one way, but feels like a solution in the realm "this is what we could implement", rather than "how it aught to be", but that's just my initial thoughts.

Would all stations have a permanent BBS advert where you could ask for a person? (This is what would make most sense for me, if it's a BBS advert). So this would be a new "service" offered on the BBS? You could select person to ask for (if having multiple missing person missions"), they would "check with their contacts, or look up in a computer for instant response"? Would it cost money to ask? Would they advice another station that might know, so player would effectively land on 3 stations? Or the BBS tipster would have the same 25% chance of spawning on the BBS? If so, when player lands they don't really know what to do, as there's just a absence of actionable things to do the "search".

impaktor · 2025-03-15T11:28:40Z

Super-nerdy thought for a future "version 10.0" of this mission: the stations in the target system could all form nodes in a directed asyclic graph, that would then just give information which next node / station the player should go to, in order to find the next clue to eventually land on correct station (node 7 below). Player might be lucky and land on node/station 4,5,6 and only need to visit one additional station

Or perhaps something like this:

impaktor · 2025-03-23T19:35:37Z

@robothauler Anything more you intend to do here, or should we just merge?

(Also, if you're interested in debug power for this module #6085 might be inspirational)

robothauler · 2025-03-23T20:21:41Z

@robothauler Anything more you intend to do here, or should we just merge?

No, not at the moment. Just merge. Would be great!

(Also, if you're interested in debug power for this module #6085 might be inspirational)

I will take a look and start a separate PR later.

zonkmachine

Looks fine to me. Maybe a bit repetitive when you've got a lot of ads at the same time.

data/modules/FindPerson/FindPerson.lua

zonkmachine · 2025-03-25T16:44:47Z

data/lang/module-findperson/en.json

+  "ADTITLE_3": {
+    "description": "",
+    "message": "SHIP FOR SEARCH REQUIRED"
+  },


I think some more adtitles/adtexts to spice up the bulletin board would be worth the effort.

Something like:

"ADTITLE_4": { "description": "", "message": "MISSING PERSON" }, ---

I think 3 are OK, if distinct, but I'm thinking some are unclear if it's a SEARCH AND RESCUE (module) for a ship or searching for a person.

impaktor · 2025-03-26T15:33:40Z

status:

I'd like to go through the en.json before merge
I'll also wait until bugfix release is out (possibly 1st of April) with merging this, as that should not be part of "zuper ztable bugfix release".

EDIT: Have done first point now.

impaktor

Left some suggestions (I did not duplicate them for male/female flavor).
Do with them as you wish.

impaktor · 2025-03-26T15:41:41Z

data/lang/module-findperson/en.json

+{
+  "ACCEPTED_DELIVER_DOCUMENT": {
+    "description": "",
+    "message": "Very well. The data has been copied."


Should it be "data" & "copied", or "document" and "transferred"/"sent"? Just going by the name of the variable, and comparing it to ACCEPTED_DELIVER_MESSAGE

impaktor · 2025-03-26T15:42:28Z

data/lang/module-findperson/en.json

+  },
+  "ACCEPTED_PRIVATEER": {
+    "description": "",
+    "message": "Good. I think you will find the ship very quickly."


"think" or "hope"?

impaktor · 2025-03-26T15:45:10Z

data/lang/module-findperson/en.json

+  },
+  "ADTITLE_1": {
+    "description": "",
+    "message": "PERSON WANTED"


PERSON WANTED indicates the PERSON wanted is the pilot/player to do mission, or PERSON is a fugitive, in my mind. If the "PERSON" is the missing one, I'd say "MISSING PERSON". I haven't checked the flavor, which is best. Just a thought.

impaktor · 2025-03-26T15:46:46Z

data/lang/module-findperson/en.json

+  "ADTITLE_3": {
+    "description": "",
+    "message": "SHIP FOR SEARCH REQUIRED"
+  },


I think 3 are OK, if distinct, but I'm thinking some are unclear if it's a SEARCH AND RESCUE (module) for a ship or searching for a person.

impaktor · 2025-03-26T15:48:22Z

data/lang/module-findperson/en.json

+  },
+  "COMPANY_6": {
+    "description": "Name of a company",
+    "message": "{name} Special IT Services Foundation"


I've been thinking of splitting out company names to a separate module. I think several other modules have company names. That would also establish which companies are in the game.
No action needed, unless you feel up to doing that now.

impaktor · 2025-03-26T16:34:10Z

data/lang/module-findperson/en.json

+  },
+  "INTROTEXT_PRIVATEER_FEMALE_1": {
+    "description": "",
+    "message": "Hi there! My name is {client}. I'm looking for {wanted}. She owes me a lot of money. According to the latest information, she's doing missions in the {system} ({sectorx}, {sectory}, {sectorz}) system. Please tell her my patience is running out. Return to {domicile} for your payment of {cash}."


or: "my patience is running thin"

impaktor · 2025-03-26T16:36:51Z

data/lang/module-findperson/en.json

+  },
+  "INTROTEXT_TAXI_FEMALE_1": {
+    "description": "",
+    "message": "Hi. I'm {client}. I'm looking for a relative in the {system} ({sectorx}, {sectory}, {sectorz}) system. Her name is {wanted}. Time is of the essence because there is a medical emergency in the family. Please find her and bring her back to {domicile}. I pay you {cash}."


Time is of the essence because there is a medical emergency in the family
->
Time is of the essence due to a medical emergency in the family

impaktor · 2025-03-26T16:52:49Z

data/lang/module-findperson/en.json

+  },
+  "MERCENARY_GREETING_MALE_3": {
+    "description": "",
+    "message": "You want to meet {wanted}? Over my dead body!"


How about "over your dead body"?
More fun, and I think it works?

impaktor · 2025-03-26T16:54:50Z

data/lang/module-findperson/en.json

+  },
+  "PIRATE_TAUNTS_3": {
+    "description": "",
+    "message": "You actually went all this way to deliver this stupid message to me? You better get out of here!"


I'd prefer "silly" over "stupid", a word/insult we've not used thus far in the game. "Silly" feels less harsh, more child friendly.

impaktor · 2025-03-26T16:57:12Z

data/lang/module-findperson/en.json

+  },
+  "SUCCESS_MSG_2": {
+    "description": "",
+    "message": "Thanks for the service. Your salary was transferred."


I'd write:
was -> has been

impaktor added the New feature label Nov 23, 2019

impaktor self-requested a review December 15, 2019 16:50

impaktor requested changes Dec 24, 2019

View reviewed changes

robothauler force-pushed the find_person branch from 8aab57b to c2d02f9 Compare December 26, 2019 19:19

impaktor reviewed Dec 29, 2019

View reviewed changes

data/lang/core/en.json Outdated Show resolved Hide resolved

src/Ship.cpp Outdated Show resolved Hide resolved

src/Ship.cpp Outdated Show resolved Hide resolved

impaktor approved these changes Jan 1, 2020

View reviewed changes

robothauler force-pushed the find_person branch from c2d02f9 to 4354969 Compare January 4, 2020 13:32

impaktor mentioned this pull request Jan 18, 2020

Add number of total docking pads at station to lobby #4773

Merged

robothauler force-pushed the find_person branch from 4354969 to fe7e6f8 Compare January 20, 2020 17:14

impaktor force-pushed the master branch 2 times, most recently from 90e4530 to 6a3a044 Compare January 26, 2023 21:29

robothauler force-pushed the find_person branch from d219462 to 17d5f56 Compare February 21, 2025 11:12

robothauler marked this pull request as draft February 21, 2025 11:29

impaktor reviewed Feb 22, 2025

View reviewed changes

robothauler force-pushed the find_person branch from bcd696f to a1f01f8 Compare March 1, 2025 10:41

robothauler marked this pull request as ready for review March 1, 2025 11:03

impaktor reviewed Mar 9, 2025

View reviewed changes

zonkmachine reviewed Mar 25, 2025

View reviewed changes

impaktor reviewed Mar 26, 2025

View reviewed changes

robothauler added 11 commits March 27, 2025 17:56

New mission: Find person

3b3bc61

Save the wanted person to the persistent characters table

c4195f6

Adapt to pigui

04a9839

Simplify

82a3762

Adapt to new BB style

243a1a0

Use the ShipBuilder to spawn the ships

f7265fd

Adapt to new equipment system

7e7b42f

Updated copyright

3201c23

Minor fixes and improvements in the wording

66b93ac

Set proper mission status

3f1310c

Tweak ads creation

1a498bb

robothauler force-pushed the find_person branch from 9799bc4 to 1a498bb Compare March 27, 2025 16:58

		@@ -0,0 +1,606 @@
		-- Copyright © 2008-2020 Pioneer Developers. See AUTHORS.txt for details

New mission: Find person #4746

Are you sure you want to change the base?

New mission: Find person #4746

Conversation

robothauler commented Nov 23, 2019 • edited by impaktor Loading

impaktor commented Nov 23, 2019 • edited Loading

mike-f1 commented Nov 24, 2019

robothauler commented Nov 25, 2019

mike-f1 commented Dec 3, 2019 • edited Loading

impaktor commented Dec 15, 2019

impaktor commented Dec 21, 2019 • edited Loading

bszlrd commented Dec 21, 2019

impaktor left a comment

Choose a reason for hiding this comment

robothauler commented Dec 26, 2019

impaktor left a comment

Choose a reason for hiding this comment

sturnclaw commented Dec 29, 2019

impaktor commented Jan 1, 2020

intro

feedback

Some more suggested changes:

robothauler commented Jan 4, 2020

robothauler commented Jan 4, 2020

impaktor commented Jan 5, 2020

robothauler commented Jan 8, 2020

impaktor commented Jan 11, 2020

Gliese852 commented Jan 13, 2020

impaktor commented Jan 16, 2020 • edited Loading

robothauler commented Jan 18, 2020

impaktor commented Jan 18, 2020

Gliese852 commented Jan 18, 2020

Gliese852 commented Jan 18, 2020

fluffyfreak commented Feb 15, 2025

Choose a reason for hiding this comment

impaktor commented Feb 22, 2025

Update 5 years later

Where do we find missing persons?

robothauler commented Feb 22, 2025

robothauler commented Mar 7, 2025

impaktor left a comment

Choose a reason for hiding this comment

LSP

debug info

other thoughts

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

impaktor Mar 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

impaktor Mar 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

impaktor Mar 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

impaktor commented Mar 15, 2025 • edited Loading

impaktor commented Mar 23, 2025

robothauler commented Mar 23, 2025

zonkmachine left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

impaktor commented Mar 26, 2025 • edited Loading

impaktor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

robothauler commented Nov 23, 2019 •

edited by impaktor

Loading

impaktor commented Nov 23, 2019 •

edited

Loading

mike-f1 commented Dec 3, 2019 •

edited

Loading

impaktor commented Dec 21, 2019 •

edited

Loading

impaktor commented Jan 16, 2020 •

edited

Loading

impaktor Mar 9, 2025 •

edited

Loading

impaktor Mar 9, 2025 •

edited

Loading

impaktor Mar 9, 2025 •

edited

Loading

impaktor commented Mar 15, 2025 •

edited

Loading

impaktor commented Mar 26, 2025 •

edited

Loading