test(server): the ACP process-tree test no longer collides with the runner's own pid

[yordis]

• The "rotates more than 64 live parents" test gives its synthetic parents pids and process groups 1000 to 1129, while the server fixture's process group is the test runner's real pid.
• A fresh CI container hands out small, sequential pids, so the runner can land inside that range. Termination then skips the matching parent as if it were the server's own group, and the test fails for reasons unrelated to the code under test.
• Choosing the range on the side away from the runner's pid makes the overlap impossible, including on hosts with a large pid_max.

[macroscopeapp]

Approvability

Verdict: Approved at 96de128

Macroscope's review found this PR approvable — This PR only adjusts an ignored ACP process-tree test to avoid a runner PID collision. Its impact is limited to test execution and does not change product behavior, defaults, or static-analysis configuration.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 755e1300-b410-474b-b468-41293450971b

---

📥 Commits

Reviewing files that changed from the base of the PR and between 6cd02e9 and 96de128.

---

📒 Files selected for processing (1)

• apps/server/src/provider/acp/AcpSessionRuntime.processTree.test.ts

---

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

---

📝 Walkthrough

Walkthrough

The bounded ownership-ledger test now selects its synthetic parent PID base based on the test runner PID. The remaining test setup and assertions are unchanged.

Changes

Process-tree test PID isolation

Layer / File(s)	Summary
Select synthetic PID base apps/server/src/provider/acp/AcpSessionRuntime.processTree.test.ts	The test uses a base of 500_000 when process.pid is lower than that value; otherwise it uses 1_000. It builds 130 synthetic parent identities from the selected base.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: juliusmarminge

---

Merge Risk: ⚪ Minimal · up to 96de1

This change is limited to test-fixture PID selection; no production behavior or merge-blocking risk is identified.

Architecture Summary

Architecture risk: 🔵 Low · up to 96de1

The change affects 1 system.

Changed systems: apps/server

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — apps/server (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in apps/server/src/provider/acp/AcpSessionRuntime.processTree.test.ts: The test now selects a synthetic parent PID base of 500_000 when process.pid < 500_000, otherwise 1_000, and builds its 130 parent identities from that base instead of always starting at 1_000. Comments describe the process-group collision this avoids.

---

Pre-merge checks | 3 | 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check		The description explains the PID collision problem and the intended fix, but it does not use the required Problem, Change, Scope and approval, and Verification sections. It also provides no verificati…	Rewrite the description using the required sections. Include the expected behavior and reproduction context under Problem, explain the PID-base change under Change, document the linked issue or maintainer approval or explain why the focused…

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check		The title clearly identifies the ACP process-tree test and the PID collision it prevents. It is concise, specific, and follows the repository's conventional commit style.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

---

Full details: Description check

Explanation

The description explains the PID collision problem and the intended fix, but it does not use the required Problem, Change, Scope and approval, and Verification sections. It also provides no verification results or approval or exemption information.

Resolution

Rewrite the description using the required sections. Include the expected behavior and reproduction context under Problem, explain the PID-base change under Change, document the linked issue or maintainer approval or explain why the focused fix qualifies under Scope and approval, and list the focused test run with observed results under Verification.

---

---

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}