refactor(source-control): Forgejo identity and Azure DevOps addressing move into their packages

[juliusmarminge]

The third cleanup layer, stacked on #17619. Two pieces of host-specific logic move out of generic server code and into their host packages.

Forgejo repository identity, from server.ts. server.ts built RepositoryIdentityResolver with about 25 lines of Forgejo logic. It parsed a Forgejo remote, asked the registry which login serves it, and derived the browser URL by stripping the installation mount.

• That logic is now refineRepositoryIdentity, a resolver the Forgejo provider implements. The code moved unchanged.
• server.ts asks each built-in driver's provider that implements it, in list order, and keeps the first change. It no longer imports from the Forgejo package.
• The provider receives a resolveContext callback instead of the registry, so it stays decoupled from the server.
• The logic had no direct test while it lived in server.ts. The package now tests an installation mount, an SSH alias, another host's identity, and a remote that no Forgejo login serves.

Azure DevOps addressing, from PullRequestService. Eight kind === "azure-devops" checks covered the list cursor key, the routing remote, which checkout serves a hosted reference, and the repository a completed action reports. All eight encode one fact: Azure DevOps names a repository by its full canonical key (host/org/project/repo).

• That fact is now the repositoryKey({ canonicalKey }) resolver, which the Azure DevOps provider implements. A host without it is identified by owner/name.
• The service resolves the key once per checkout into SupportedProject.repositoryKey and routes on that.

Behavior is unchanged.

Left out on purpose:

• PullRequestService still has six Forgejo checks and pullRequestSyncKey has one Azure DevOps check. All of them go through pullRequestHostOf in contracts, which branches on "forgejo", and five web files call that function so the page and server agree on host names. They belong in the client layer, together with the branded kind and the client definitions.
• The dev.azure.com host-narrowing shortcut in requireProject was already on main. I filed it as a follow-up instead of growing this layer.

Verified with tsc, knip, a frozen-lockfile install, and the open stack's tests (52 files, 1211 tests). The Effect-shortcut grep finds no hits in the added lines.

🤖 Generated with Claude Code — Claude Opus 5.5 in T3 Code

[macroscopeapp]

Approvability

Verdict: Approved at 5012fa4

Macroscope's review found this PR approvable — This is a contained source-control refactor that moves existing Forgejo and Azure DevOps behavior behind provider-owned capabilities without introducing a new workflow or changing product defaults. The runtime paths for existing providers retain their prior behavior, with focused tests added for the relocated Forgejo logic.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	—	4.9 KiB	—	6.8 KiB	✅
Codex	Thread snapshot wire	—	3.8 KiB	—	4.9 KiB	✅
Codex	Live turn WebSocket wire	—	1.2 KiB	—	2.0 KiB	✅
Codex	Live turn WebSocket decoded	—	20.8 KiB	—	29.3 KiB	✅
Codex	Live turn messages	—	1	—	8	✅
Claude	Total thread wire	—	5.0 KiB	—	6.8 KiB	✅
Claude	Thread snapshot wire	—	3.8 KiB	—	4.9 KiB	✅
Claude	Live turn WebSocket wire	—	1.2 KiB	—	2.0 KiB	✅
Claude	Live turn WebSocket decoded	—	21.2 KiB	—	29.3 KiB	✅
Claude	Live turn messages	—	1	—	8	✅

Baseline: unavailable · PR result: 5012fa4 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: 017bbf17-1ede-4e45-ac7b-30a31c27118c

---

📥 Commits

Reviewing files that changed from the base of the PR and between 771f9d4 and 5012fa4.

---

📒 Files selected for processing (6)

• apps/server/src/pullRequest/PullRequestService.test.ts
• apps/server/src/pullRequest/PullRequestService.ts
• apps/server/src/server.ts
• packages/source-control-azure-devops/src/server/AzureDevOpsPullRequestProvider.ts
• packages/source-control-core/src/server/PullRequestProvider.ts
• packages/source-control-core/src/server/SourceControlProvider.ts

---

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

---

---

📝 Walkthrough

Walkthrough

The pull request adds provider-supplied repository keys for pull request routing. It also adds provider-based repository identity refinement, which the server delegates to built-in source-control providers, including Forgejo.

Changes

Canonical repository addressing

Layer / File(s)	Summary
Declare canonical repository keys packages/source-control-core/src/server/PullRequestProvider.ts, packages/source-control-azure-devops/src/server/AzureDevOpsPullRequestProvider.ts	The pull request provider API adds an optional repositoryKey resolver. Azure DevOps returns the supplied canonical key.
Apply canonical repository keys apps/server/src/pullRequest/PullRequestService.ts, apps/server/src/pullRequest/PullRequestService.test.ts	The service uses provider repository keys for project deduplication, remotes, hosted-reference routing, and action results. The test fixture adds a repository-key resolver.

Provider-based identity refinement

Layer / File(s)	Summary
Define and implement identity refinement packages/source-control-core/src/server/SourceControlProvider.ts, packages/source-control-forgejo/src/server/ForgejoSourceControlProvider.ts, packages/source-control-forgejo/src/server/ForgejoSourceControlProvider.test.ts	The source-control provider API adds a refinement callback. Forgejo implements it for eligible remotes. Tests cover mounted HTTP and SSH paths and unchanged identities.
Delegate refinement to built-in drivers apps/server/src/server.ts	The server invokes available refinement callbacks and returns the first changed identity, or the original identity if no provider changes it.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Refactor

Sequence Diagram(s)

sequenceDiagram
  participant Server
  participant BuiltInSourceControlProviders
  participant ForgejoSourceControlProvider
  participant ResolveContext
  Server->>BuiltInSourceControlProviders: Iterate through providers
  BuiltInSourceControlProviders->>ForgejoSourceControlProvider: Call refineRepositoryIdentity
  ForgejoSourceControlProvider->>ResolveContext: Resolve Forgejo context for cwd
  ResolveContext-->>ForgejoSourceControlProvider: Return provider context or null
  ForgejoSourceControlProvider-->>Server: Return refined or unchanged identity

Loading

Suggested reviewers: maria-rcks

---

Merge Risk: ⚪ Minimal · up to 5012f

No actionable merge-blocking issue is established; the change is mergeable after normal checks.

Pre-merge checks | 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly and concisely identifies the main refactor: moving Forgejo identity handling and Azure DevOps addressing into their provider packages.
Description check		The description explains the problem, the changes, the intentional scope limits, and focused verification results. It does not use the template headings or provide explicit maintainer approval details…

---

---

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

---

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}