Repository navigation
fix(web): show live names in thread-read activity - #13140
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, self-contained web timeline fix that derives live thread names from existing client state and adds a settled-row link while preserving generic fallbacks. Its runtime impact is limited to presentation and navigation for thread-read activity, with focused helper tests and no schema, deployment, or sensitive-area changes. You can add or adjust custom eligibility rules. Learn more. |
a419382 to
f2bdd9f
Compare
1fcdb1c to
d9b7330
Compare
Dismissing prior approval to re-evaluate 2332b93
060756d to
d6dcd10
Compare
2332b93 to
235ede3
Compare
d2675dc to
9cbaf77
Compare
235ede3 to
48b64e2
Compare
Dismissing prior approval to re-evaluate 48b64e2
6ca6a24 to
3e4ca4c
Compare
48b64e2 to
6bdfff1
Compare
1bd44f2 to
3b9c885
Compare
6bdfff1 to
8eeb330
Compare
This comment has been minimized.
This comment has been minimized.
Dismissing prior approval to re-evaluate b15da98
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
6448cfe to
1563a64
Compare
b15da98 to
51614af
Compare
fe4f6ad to
87c67bd
Compare
51614af to
401dc23
Compare
|
Note This comment is posted by Julius' dot The supplied screenshots show the renamed labels, but not the title-link and row-expansion interaction. Could you add a short recording showing the target opening, the rest of the row expanding, and a rename reaching the same row, plus a before screenshot? This would complete the UI verification evidence while preserving Julius' inline-label rewrite. |
Dismissing prior approval to re-evaluate 58d86fe
|
Macroscope has since reviewed this pull request. An earlier review was skipped by a cost limit; a review has now completed, so that notice no longer applies. |
58d86fe to
098baaf
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe message timeline now identifies thread-read work entries, resolves eligible thread titles, and displays them in live and settled rows. Live titles are plain text. Settled titles link to the thread. ChangesThread-read presentation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~15 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to Eligible thread names appear in activity labels, and settled titles link to their threads. No actionable merge risk is established. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the problem, change, UI behavior, and verification. It does not include the required Scope and approval section, and it does not provide the requested recording and before screenshot for the link, expansion, and rename interactions. Resolution Add a Scope and approval section with the linked issue or explicit maintainer approval, or explain why this focused fix qualifies for an exemption. Add a before screenshot and a short recording that demonstrates opening the target thread, expanding the row outside the title, and seeing a rename update the same row.
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Replay the contribution onto current main and resolve integration changes. Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: PR Batch Tester <agent@local.test>
098baaf to
ebf999f
Compare
## What's Changed * feat(models): add Claude Haiku 5.5 and retire Sonnet 5 and Opus 5 to legacy by @juliusmarminge in pingdotgg/t3code#16903 * fix(web): iPhone Duo folds animate, center on the hinge, and keep the phone's orientation by @gabrielelpidio in pingdotgg/t3code#16885 * fix(server): Claude 5-series models always run 1M context by @juliusmarminge in pingdotgg/t3code#16908 * fix(desktop): setup prompts name a t3 that runs on desktop installs by @juliusmarminge in pingdotgg/t3code#16676 * feat(desktop): install the t3 command from Settings by @juliusmarminge in pingdotgg/t3code#16683 * fix(web): show live names in thread-read activity by @Bil0000 in pingdotgg/t3code#13140 * feat(mobile): adopt v5 navigation and native iPad columns by @juliusmarminge in pingdotgg/t3code#16733 * fix(mobile): Android composer picker scrolls past the first four rows by @shivamhwp in pingdotgg/t3code#15856 * fix(desktop): sign-in and captchas work again in desktop browser tabs by @juliusmarminge in pingdotgg/t3code#16939 * fix(server): missing project folders no longer log favicon warnings by @yordis in pingdotgg/t3code#16757 * fix(server): unload Codex threads left idle on the shared app-server by @RhysSullivan in pingdotgg/t3code#16917 * fix(web): fast typing no longer scrambles text when type-to-focus kicks in by @otavio in pingdotgg/t3code#14595 * fix(web): simplify workspace card rows by @Bil0000 in pingdotgg/t3code#16823 * fix(web): Copy MCP URL shows up for environments reached over plain http by @SunkenInTime in pingdotgg/t3code#16909 * fix(web): C#, Java, PHP and 11 other languages get file icons by @juliusmarminge in pingdotgg/t3code#16974 * feat(clients): live row shows the agent's latest thought by @t3dotgg in pingdotgg/t3code#16284 * feat(web): block-level Markdown in the rich text composer by @chrisdeeming in pingdotgg/t3code#14677 * fix(web): center project monograms in settled rows by @Aforno in pingdotgg/t3code#16841 * fix(web): cancelling a new citation no longer leaves a stray space by @Aforno in pingdotgg/t3code#16828 * fix(settings): provider updates show live progress instead of a bare spinner by @shivamhwp in pingdotgg/t3code#16958 * feat(web): find in diffs with Cmd+F by @juliusmarminge in pingdotgg/t3code#14623 * refactor(server): GitHub services are named for the API they call, not gh by @juliusmarminge in pingdotgg/t3code#16967 * refactor(server): GitHub GraphQL batches use variables and share one pager by @juliusmarminge in pingdotgg/t3code#16960 * refactor(server): GitHub source control reads GitHubApi directly by @juliusmarminge in pingdotgg/t3code#16982 * refactor(server): GitHub rate limits read the response headers by @juliusmarminge in pingdotgg/t3code#16986 ## New Contributors * @RhysSullivan made their first contribution in pingdotgg/t3code#16917 * @Aforno made their first contribution in pingdotgg/t3code#16841 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261007.2787...v0.0.46-nightly.20261008.2801 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261008.2801
## What's Changed * feat(models): add Claude Haiku 5.5 and retire Sonnet 5 and Opus 5 to legacy by @juliusmarminge in pingdotgg/t3code#16903 * fix(web): iPhone Duo folds animate, center on the hinge, and keep the phone's orientation by @gabrielelpidio in pingdotgg/t3code#16885 * fix(server): Claude 5-series models always run 1M context by @juliusmarminge in pingdotgg/t3code#16908 * fix(desktop): setup prompts name a t3 that runs on desktop installs by @juliusmarminge in pingdotgg/t3code#16676 * feat(desktop): install the t3 command from Settings by @juliusmarminge in pingdotgg/t3code#16683 * fix(web): show live names in thread-read activity by @Bil0000 in pingdotgg/t3code#13140 * feat(mobile): adopt v5 navigation and native iPad columns by @juliusmarminge in pingdotgg/t3code#16733 * fix(mobile): Android composer picker scrolls past the first four rows by @shivamhwp in pingdotgg/t3code#15856 * fix(desktop): sign-in and captchas work again in desktop browser tabs by @juliusmarminge in pingdotgg/t3code#16939 * fix(server): missing project folders no longer log favicon warnings by @yordis in pingdotgg/t3code#16757 * fix(server): unload Codex threads left idle on the shared app-server by @RhysSullivan in pingdotgg/t3code#16917 * fix(web): fast typing no longer scrambles text when type-to-focus kicks in by @otavio in pingdotgg/t3code#14595 * fix(web): simplify workspace card rows by @Bil0000 in pingdotgg/t3code#16823 * fix(web): Copy MCP URL shows up for environments reached over plain http by @SunkenInTime in pingdotgg/t3code#16909 * fix(web): C#, Java, PHP and 11 other languages get file icons by @juliusmarminge in pingdotgg/t3code#16974 * feat(clients): live row shows the agent's latest thought by @t3dotgg in pingdotgg/t3code#16284 * feat(web): block-level Markdown in the rich text composer by @chrisdeeming in pingdotgg/t3code#14677 * fix(web): center project monograms in settled rows by @Aforno in pingdotgg/t3code#16841 * fix(web): cancelling a new citation no longer leaves a stray space by @Aforno in pingdotgg/t3code#16828 * fix(settings): provider updates show live progress instead of a bare spinner by @shivamhwp in pingdotgg/t3code#16958 * feat(web): find in diffs with Cmd+F by @juliusmarminge in pingdotgg/t3code#14623 * refactor(server): GitHub services are named for the API they call, not gh by @juliusmarminge in pingdotgg/t3code#16967 * refactor(server): GitHub GraphQL batches use variables and share one pager by @juliusmarminge in pingdotgg/t3code#16960 * refactor(server): GitHub source control reads GitHubApi directly by @juliusmarminge in pingdotgg/t3code#16982 * refactor(server): GitHub rate limits read the response headers by @juliusmarminge in pingdotgg/t3code#16986 ## New Contributors * @RhysSullivan made their first contribution in pingdotgg/t3code#16917 * @Aforno made their first contribution in pingdotgg/t3code#16841 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261007.2787...v0.0.46-nightly.20261008.2801 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261008.2801
What Changed
“Read a T3 thread” activity now names the thread it read, on one line:
Read thread “Review auth flow”, in the tool’s tense (Reading / Read / Failed to read). On finished rows the title links to that thread; clicking anywhere else on the row still expands the tool call. The title comes from client shell state, so a rename shows up without a DB join. If the thread is unknown, archived or deleted, the row keeps the generic “Read a T3 thread” label and no link.Why
The tool label alone does not identify the target thread.
UI Changes
Finished row. The title links to the thread; an unknown thread keeps the generic label:
After renaming the target thread, the same row shows the new name:
While the call runs, the live row reads in the present tense:
Scope and approval
This is a small, focused display fix for an existing thread-read activity. The generic label does not identify the thread that was read. It uses the thread ID already present in the tool input and the existing thread route. The change stays in the web timeline and its tests. Web and desktop share this timeline. Mobile rendering is outside this web-only change. The single-line layout preserves the rewrite by Julius.
Verification
All 237 focused MessagesTimeline component and logic tests pass under Node 24.13.1. The new regression failed before the fix, then passed after it. Web typecheck, scoped lint, format, and diff checks passed. In the isolated real app, a test tool row opened its target, expanded when clicked outside the title, and picked up a rename through the normal app command. Archiving and deleting the target removed the title link; unarchiving restored it. Test projection data was used for the tool row. All current CI checks passed, and CodeRabbit and Macroscope approved this head.
Before, on current main:
After, with the renamed title and expanded details:
The 36-second recording shows the title opening the target, the rest of the row expanding, and a rename updating that same row. Playback is sped up to remove tool wait time.
pr13140-interaction.mp4
Checklist
Model: GPT-6 Codex (native Codex harness). Single-line redesign by Claude Opus 5.5 (Claude Code). Review fixes and verification: GPT-6.1-Sol (Codex harness).