Repository navigation
feat(web): port compact workspace menu from ov2 - #12812
maria-rcks wants to merge 3 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR introduces a substantial workspace and version-control menu that changes the default chat-header experience and touches multiple interactive controls and lifecycle paths. Its cross-component user-facing impact is broader than a bounded UI adjustment. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe PR adds panel layouts for branch, environment, script, editor, and Git controls. Chat headers now group these controls in workspace and version-control sections within a persistent popover. Toolbar layouts remain the default. ChangesThread details panel controls
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Feature 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ports ov2's workspace and version control popup into main's chat header, using a 256px width, 28px rows, 12px text, 8px section padding, and 2px row gaps. existing branch, editor, script, and git handlers remain in use, and open dialogs survive closing the menu or resizing.
verified in the real app: workspace mode changes, a provider turn, adding/running/editing a project script, nested editor/git menus, escape dismissal, and changes opening the diff panel. inspected desktop and phone widths in dark and light themes. blacksmith web typecheck, scoped lint, and 161 existing tests passed; the spacing follow-up passed web typecheck, scoped lint, and 78 existing tests.
model: gpt-6. harness: codex.