Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with TiDB mater (v6.5.0) (#2598) #2602

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2598

What problem does this PR solve?

This pr fix three errors:

  • SHARD_ROW_ID_BITS can't work with cluster index
  • Write (replace=true) with date type commonhandle may fail to do upsert. because we don't handle the date type correctly when build commonhandle
  • random tests need to specify non-cluster index for TiDB mater default to cluster index now.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shiyuhang0
  • zhangyangyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shiyuhang0
Copy link
Member

/run-all-tests

@shiyuhang0
Copy link
Member

/run-all-tests

@shiyuhang0
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

@shiyuhang0: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@shiyuhang0
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: f00301c

@ti-chi-bot ti-chi-bot merged commit 9d93677 into pingcap:release-3.1 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants