Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatible with TiDB mater (v6.5.0) #2598

Merged
merged 10 commits into from
Dec 9, 2022
Merged

Compatible with TiDB mater (v6.5.0) #2598

merged 10 commits into from
Dec 9, 2022

Conversation

shiyuhang0
Copy link
Member

@shiyuhang0 shiyuhang0 commented Dec 6, 2022 •
edited
Loading

What problem does this PR solve?

This pr fix three errors:

  • SHARD_ROW_ID_BITS can't work with cluster index
  • Write (replace=true) with date type commonhandle may fail to do upsert. because we don't handle the date type correctly when build commonhandle
  • random tests need to specify non-cluster index for TiDB mater default to cluster index now.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xuanyu66
  • zhangyangyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shiyuhang0
Copy link
Member Author

/run-all-test tidb=v6.1.0 tikv=v6.1.0

@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=v6.1.0 tikv=v6.1.0

@shiyuhang0
Copy link
Member Author

/run-all-tests

1 similar comment
@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0 shiyuhang0 changed the title [DNM]test stable Compatible with TiDB mater (v6.5.0) Dec 8, 2022
@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0 shiyuhang0 added needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4 needs-cherry-pick-release-2.5 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.0 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 labels Dec 9, 2022
@shiyuhang0
Copy link
Member Author

/run-all-tests

birdstorm
birdstorm approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c2072e2

@ti-chi-bot ti-chi-bot merged commit 47d082c into pingcap:master Dec 9, 2022
@ti-srebot
Copy link
Collaborator

cherry pick to release-release failed

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 9, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2602.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Dec 9, 2022
@shiyuhang0 @ti-chi-bot
This is an automated cherry-pick of pingcap#2598
52fd7b7 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 9, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2603.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Dec 9, 2022
@shiyuhang0 @ti-chi-bot
This is an automated cherry-pick of pingcap#2598
ef96d80 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2604.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Dec 9, 2022
@shiyuhang0 @ti-chi-bot
This is an automated cherry-pick of pingcap#2598
0fcc30c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Dec 9, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2605.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Dec 9, 2022
@shiyuhang0 @ti-chi-bot
This is an automated cherry-pick of pingcap#2598
e671217 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Dec 12, 2022
@ti-chi-bot
Compatible with TiDB mater (v6.5.0) (#2598) (#2602)
9d93677
ti-chi-bot added a commit that referenced this pull request Dec 12, 2022
@ti-chi-bot
Compatible with TiDB mater (v6.5.0) (#2598) (#2605)
1b9a871
@shiyuhang0 shiyuhang0 mentioned this pull request Dec 12, 2022
Closed
ti-chi-bot added a commit that referenced this pull request Dec 19, 2022
@ti-chi-bot
Compatible with TiDB mater (v6.5.0) (#2598) (#2603)
2892fb0
ti-chi-bot added a commit that referenced this pull request Dec 19, 2022
@ti-chi-bot
Compatible with TiDB mater (v6.5.0) (#2598) (#2604)
bf2d377
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@shiyuhang0
Compatible with TiDB mater (v6.5.0) (pingcap#2598)
fce85ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangyangyu zhangyangyu zhangyangyu approved these changes

@birdstorm birdstorm birdstorm approved these changes

@xuanyu66 xuanyu66 xuanyu66 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4 needs-cherry-pick-release-2.5 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.0 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shiyuhang0 @ti-chi-bot @ti-srebot @zhangyangyu @birdstorm @xuanyu66