Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observer, net: read packet from SQL port in health check #578

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #577

Problem Summary:
#510 removes reading one packet from the SQL port, but some TiDB versions don't respond after establishing the TCP connection before finishing loading statistics.

Handshake until TLS is complicated. It needs to consider capabilities like proxy-protocol and TLS. So maybe I'll use another way to detect the validity of TLS certs.

What is changed and how it works:
Read one packet from the SQL port in health checking.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox June 25, 2024 04:04
@ti-chi-bot ti-chi-bot bot added the size/M label Jun 25, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@aa36952). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage        ?   67.52%           
=======================================
  Files           ?       76           
  Lines           ?     6900           
  Branches        ?        0           
=======================================
  Hits            ?     4659           
  Misses          ?     1904           
  Partials        ?      337           
Flag Coverage Δ
unit 67.52% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

ti-chi-bot bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jun 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-25 04:25:12.759395153 +0000 UTC m=+693639.244883985: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 00d7eac into pingcap:main Jun 25, 2024
5 checks passed
@djshow832 djshow832 deleted the sql_port branch June 25, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check SQL port until TLS handshake
3 participants