observer, net: read packet from SQL port in health check #578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #577
Problem Summary:
#510 removes reading one packet from the SQL port, but some TiDB versions don't respond after establishing the TCP connection before finishing loading statistics.
Handshake until TLS is complicated. It needs to consider capabilities like proxy-protocol and TLS. So maybe I'll use another way to detect the validity of TLS certs.
What is changed and how it works:
Read one packet from the SQL port in health checking.
Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.