Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observer: read the server version from HTTP status #510

Merged
merged 4 commits into from
Apr 17, 2024
Merged

observer: read the server version from HTTP status #510

merged 4 commits into from
Apr 17, 2024

Conversation

yorkhellen
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #456

Problem Summary:
refactor: read the server version from HTTP status response body instead of the initial handshake
What is changed and how it works:
read the server version from HTTP status response body, suck like:

{"connections":0,"version":"8.0.11-TiDB-v8.0.0","git_hash":"8ba1fa452b1ccdbfb85879ea94b9254aabba2916"}

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Apr 16, 2024

Hi @yorkhellen. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/L label Apr 16, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 17, 2024
Copy link

ti-chi-bot bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-17 06:01:25.697575491 +0000 UTC m=+404304.808621938: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot added the approved label Apr 17, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@bbfad0b). Click here to learn what that means.

Files Patch % Lines
pkg/balance/observer/health_check.go 70.83% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #510   +/-   ##
=======================================
  Coverage        ?   64.86%           
=======================================
  Files           ?       65           
  Lines           ?     6096           
  Branches        ?        0           
=======================================
  Hits            ?     3954           
  Misses          ?     1837           
  Partials        ?      305           
Flag Coverage Δ
unit 64.86% <70.83%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read the server version from HTTP status
3 participants