Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributing(all): update minimal go version, add engine in commit message #5522

Merged
merged 6 commits into from
May 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions .github/ISSUE_TEMPLATE/engine-bug-report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: "\U0001F41B Dataflow Engine Bug Report"
description: Something isn't working as expected
labels: ["type/bug","area/engine"]
body:
- type: markdown
attributes:
value: |
Please answer these questions before submitting your issue. Thanks!
- type: textarea
id: problem
attributes:
label: What did you do?
description: If possible, provide a recipe for reproducing the error.
validations:
required: true
- type: textarea
id: expect
attributes:
label: What did you expect to see?
validations:
required: false
- type: textarea
id: see
attributes:
label: What did you see instead?
validations:
required: true
- type: textarea
id: version
attributes:
label: Versions of the cluster
value: |-
Dataflow Engine version:

```console
(paste Dataflow Engine version here)
```
validations:
required: true
10 changes: 6 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ your contribution accepted.

Developing TiDB-CDC requires:

* [Go 1.16+](https://go.dev/doc/code)
* [Go 1.18+](https://go.dev/doc/code)
* An internet connection to download the dependencies

Simply run `make` to build the program.
Expand Down Expand Up @@ -76,7 +76,7 @@ Improve documentation.
The format can be described more formally as follows:

```
<subsystem>(ticdc|dm|both): <what changed>
<subsystem>(ticdc|dm|engine|all): <what changed>
<BLANK LINE>
<why this change was made>
<BLANK LINE>
Expand All @@ -90,8 +90,10 @@ git tools.
If the change affects more than one subsystem, you can use comma to separate them like ```capture,puller:```. If the
change affects many subsystems, you can use ```*``` instead, like ```*:```.

If this change affects ticdc, fill in ```<subsystem>(ticdc)```, if it affects dm, fill in ```<subsystem>(dm)```. If it
involves a code that is used by both products, fill in ```<subsystem>(both)```.
If this change only affects ticdc, fill in ```<subsystem>(ticdc)```,
if it only affects dm, fill in ```<subsystem>(dm)```,
if it only affects dataflow engine, fill in ```<subsystem>(engine)```.
If it involves a code that is used by all products, fill in ```<subsystem>(all)```.

For the why part, if no specific reason for the change, you can use one of some generic reasons like "Improve
documentation.",
Expand Down