Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributing(all): update minimal go version, add engine in commit message #5522

Merged
merged 6 commits into from
May 23, 2022

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented May 23, 2022

What problem does this PR solve?

Issue Number: ref #5352

Finish task 2 in #5352

What is changed and how it works?

  • Minimal go version is go1.18
  • Add engine option in commit message.
  • Add bug report issue template for dataflow engine.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 23, 2022
@amyangfei amyangfei added the status/ptal Could you please take a look? label May 23, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 23, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #5522 (bc740ce) into master (e62fbea) will decrease coverage by 0.1449%.
The diff coverage is n/a.

Flag Coverage Δ
cdc 61.4967% <ø> (+0.0102%) ⬆️
dm 51.9841% <ø> (+0.0177%) ⬆️
engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5522        +/-   ##
================================================
- Coverage   56.3160%   56.1711%   -0.1449%     
================================================
  Files           675        530       -145     
  Lines         78594      69947      -8647     
================================================
- Hits          44261      39290      -4971     
+ Misses        30143      26890      -3253     
+ Partials       4190       3767       -423     

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 23, 2022
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bc740ce

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2022
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@amyangfei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506 Rustin170506 removed the status/ptal Could you please take a look? label May 23, 2022
@lance6716
Copy link
Contributor

/run-kafka-integration-test
/run-leak-test

@ti-chi-bot ti-chi-bot merged commit 8c90140 into pingcap:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants