-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/log(dm):support reading fields from Ctx #5518
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Really fast CPU 🚀 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6900b47
|
/run-dm-integration-test |
1 similar comment
/run-dm-integration-test |
What problem does this PR solve?
Issue Number: close #5517
What is changed and how it works?
context.WithValue
.WithCtx()
method tolog
package, so that in each function call, the fields can be logged easily.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Using
WithCtx
increases time cost by 50% compared to traditional, but more complex methods. But given the baseline high performance ofzap
, it should be fine as long as no logging is used in CPU intensive operations.Release note