Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: We need a better mechanism for structured logging #5517

Closed
1 task
liuzix opened this issue May 23, 2022 · 0 comments · Fixed by #5518
Closed
1 task

engine: We need a better mechanism for structured logging #5517

liuzix opened this issue May 23, 2022 · 0 comments · Fixed by #5518
Assignees
@liuzix
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@liuzix
Copy link
Contributor

liuzix commented May 23, 2022

The problem:

Many of the logs in Data Flow Engine needs to be tagged with metadata of the request/job/tenant/worker, etc. So we need a mechanism to easily attach these fields to the logger.

  • Add necessary features to dm/pkg/log.
@liuzix liuzix added the type/enhancement The issue or PR belongs to an enhancement. label May 23, 2022
@liuzix liuzix self-assigned this May 23, 2022
@liuzix liuzix mentioned this issue May 23, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue May 24, 2022
@liuzix
pkg/log(dm):support reading fields from Ctx (#5518)
cca66c1 
close #5517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liuzix liuzix

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pkg/log(dm):support reading fields from Ctx liuzix/ticdc
1 participant
@liuzix