New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics(ticdc): add resolved ts and add changefeed to dataflow #4038

Merged

ti-chi-bot merged 7 commits into pingcap:master from overvenus:fix-metircs1

Dec 28, 2021

Member

overvenus commented Dec 23, 2021 •

edited

Loading

What problem does this PR solve?

fix etcd worker txn size heatmap
add owner resolved ts metrics
add changefeed to dataflow
add PD uptime
add PD leader history
add etcd metrics, eg, mvcc db size, etc.

Check List

Tests

Manual test (add detailed scripts or steps below)

Import to grafana.

Related changes

Need to cherry-pick to the release branch

Release note

None

overvenus added 2 commits

December 21, 2021 15:22


          fix etcd worker txn size heatmap

f1a07a6

Signed-off-by: Neil Shen <overvenus@gmail.com>


          metrics(ticdc): add resolved ts and add changefeed to dataflow

d53909c

Signed-off-by: Neil Shen <overvenus@gmail.com>

overvenus added needs-cherry-pick-release-4.0 needs-cherry-pick-release-5.0 component/metrics-logging needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 labels

Member

ti-chi-bot commented Dec 23, 2021 •

edited

Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

amyangfei
asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot added release-note-none size/L labels

overvenus added 3 commits

December 25, 2021 23:24


          metrics(ticdc): add pd and etcd metrics

3aef729

Signed-off-by: Neil Shen <overvenus@gmail.com>


          owner(ticdc): add owner resolved ts and resolved lag metrics

d08a274

Signed-off-by: Neil Shen <overvenus@gmail.com>


          metrics(ticdc): adjust etcd rows

f345fea

Signed-off-by: Neil Shen <overvenus@gmail.com>

ti-chi-bot added size/XXL and removed size/L labels

codecov-commenter commented Dec 25, 2021

Codecov Report

Merging #4038 (f345fea) into master (3873d39) will decrease coverage by 1.9268%.
The diff coverage is 64.0553%.

Flag	Coverage Δ
cdc	`58.1101% <64.0553%> (-0.1265%)`	⬇️
dm	`52.6427% <ø> (-3.3919%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4038        +/-   ##
================================================
- Coverage   57.0741%   55.1472%   -1.9269%     
================================================
  Files           478        484         +6     
  Lines         56551      59002      +2451     
================================================
+ Hits          32276      32538       +262     
- Misses        20978      23165      +2187     
- Partials       3297       3299         +2

amyangfei reviewed

View reviewed changes

metrics/grafana/ticdc.json

    
                        "targets": [

                          {

                            "expr": "histogram_quantile(0.999, sum(rate(ticdc_server_etcd_health_check_duration_bucket{tidb_cluster=\"$tidb_cluster\", capture=~\"$capture\"}[1m])) by (le,instance))",

                            "expr": "pd_tso_role{tidb_cluster=\"$tidb_cluster\", dc=\"global\"} > BOOL 0.5",

Contributor

amyangfei Dec 27, 2021

Please describe how many changes have been applied to dashboard, since the diff is large enough.

Member Author

overvenus Dec 27, 2021

Updated, thanks for reminding!

asddongmen approved these changes

View reviewed changes

ti-chi-bot added the status/LGT1 label

amyangfei approved these changes

View reviewed changes

ti-chi-bot added status/LGT2 and removed status/LGT1 labels

Member Author

overvenus commented Dec 28, 2021

/merge

Member

ti-chi-bot commented Dec 28, 2021

This pull request has been accepted and is ready to merge.

Commit hash: f345fea

ti-chi-bot added the status/can-merge label


          Merge branch 'master' into fix-metircs1

3b2e05b

Member Author

overvenus commented Dec 28, 2021

/run-integration-test
/run-dm-integration-test


          Merge branch 'master' into fix-metircs1

07d1da2

Member Author

overvenus commented Dec 28, 2021

/run-leak-test
/run-verify

Member Author

overvenus commented Dec 28, 2021

/run-dm-integration-test

ti-chi-bot merged commit 20e3f13 into pingcap:master

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request


          This is an automated cherry-pick of pingcap#4038

cc5ca0e

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

Member

ti-chi-bot commented Dec 28, 2021

In response to a cherrypick label: new pull request created: #4101.

ti-chi-bot mentioned this pull request

metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) #4101

Merged

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request


          This is an automated cherry-pick of pingcap#4038

04d068d

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request

metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) #4102

Merged

Member

ti-chi-bot commented Dec 28, 2021

In response to a cherrypick label: new pull request created: #4102.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request


          This is an automated cherry-pick of pingcap#4038

20587db

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request

metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) #4103

Merged

Member

ti-chi-bot commented Dec 28, 2021

In response to a cherrypick label: new pull request created: #4103.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request


          This is an automated cherry-pick of pingcap#4038

9ff143a

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request

metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) #4104

Merged

Member

ti-chi-bot commented Dec 28, 2021

In response to a cherrypick label: new pull request created: #4104.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request


          This is an automated cherry-pick of pingcap#4038

728b7a8

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request

metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) #4105

Merged

Member

ti-chi-bot commented Dec 28, 2021

In response to a cherrypick label: new pull request created: #4105.

zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request


          metrics(ticdc): add resolved ts and add changefeed to dataflow (pingc…

43b54fe

…ap#4038)

ti-chi-bot added a commit that referenced this pull request


          metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (

981aaf5

#4105)

ti-chi-bot added a commit that referenced this pull request


          metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (

4954aa1

#4102)

ti-chi-bot added a commit that referenced this pull request


          metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (

11039ae

#4103)

ti-chi-bot added a commit that referenced this pull request


          metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (

2a25cf6

#4104)

3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this pull request


          metrics(ticdc): add resolved ts and add changefeed to dataflow (pingc…

…ap#4038) (pingcap#4103)

3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this pull request


          metrics(ticdc): add resolved ts and add changefeed to dataflow (pingc…

ed96ff4

…ap#4038) (pingcap#4104)

ti-chi-bot added a commit that referenced this pull request


          metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (

102b65f

#4101)

overvenus pushed a commit that referenced this pull request


          metrics(cdc): fix mq sink write row count metrics. (#4192) (#4322)

a5ce862

* fix the txn_batch_size metric inaccuracy bug when the sink target is MQ

* address comments

* add comments for exported functions

* fix the compiling problem

* workerpool: limit the rate to output deadlock warning (#3775) (#3799)

* metrics: add changefeed checkepoint catch-up ETA (#3300) (#3311)

* pkg,cdc: do not use log package (#3902) (#3939)

* *: rename repo from pingcap/ticdc to pingcap/tiflow (#3957)

* kvclient(ticdc): fix kvclient takes too long time to recover (#3612) (#3662)

* tz (ticdc): fix timezone error (#3887) (#3910)

* http_*: add log for http api and refine the err handle logic (#2997) (#3306)

* ticdc/alert: add no owner alert rule (#3809) (#3831)

* etcd_worker: batch etcd patch (#3277) (#3393)

* ticdc/owner: Fix ddl special comment syntax error (#3845) (#3977)

* Clean old owner and old processor in release 5.2 branch (#4019)

* tests(ticdc): set up the sync diff output directory correctly (#3725) (#3745)

* owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) (#4015)

* config(ticdc): Fix old value configuration check for maxwell protocol (#3747) (#3782)

* ticdc/processor: Fix backoff base delay misconfiguration (#3992) (#4027)

* sink(ticdc): cherry pick sink bug fix to release 5.2 (#4083) (#4119)

* metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (#4103)

* kv(ticdc): reduce eventfeed rate limited log (#4072) (#4110)

close #4006

* This is an automated cherry-pick of #4192

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* http_api (ticdc): fix http api 'get processor' panic. (#4117) (#4122)

close #3840

* cdc/sink: adjust kafka initialization logic (#3192) (#3568)

* This is an automated cherry-pick of #3192

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* fix conflicts.

* This is an automated cherry-pick of #3682

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* fix import.

* fix failpoint path.

* try to fix initialize.

* remove table_sink.

* remove initialization.

* remove owner.

* fix mq.

Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>
Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>

* sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (#4084) (#4098)

close #4055

* This is an automated cherry-pick of #4192

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* fix conflicts.

* fix conflicts.

* fix conflicts.

Co-authored-by: zhaoxinyu <zhaoxinyu512@gmail.com>
Co-authored-by: amyangfei <yangfei@pingcap.com>
Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com>
Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>
Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>

overvenus pushed a commit that referenced this pull request


          metrics(cdc): fix mq sink write row count metrics. (#4192) (#4323)

ae04769

* fix the txn_batch_size metric inaccuracy bug when the sink target is MQ

* address comments

* add comments for exported functions

* fix the compiling problem

* workerpool: limit the rate to output deadlock warning (#3775) (#3795)

* tests(ticdc): set up the sync diff output directory correctly (#3725) (#3741)

* relay(dm): use binlog name comparison (#3710) (#3712)

* dm/load: fix concurrent call Loader.Status (#3459) (#3468)

* cdc/sorter: make unified sorter cgroup aware (#3436) (#3439)

* tz (ticdc): fix timezone error (#3887) (#3906)

* pkg,cdc: do not use log package (#3902) (#3940)

* *: rename repo from pingcap/ticdc to pingcap/tiflow (#3959)

* http_*: add log for http api and refine the err handle logic (#2997) (#3307)

* etcd_worker: batch etcd patch (#3277) (#3389)

* http_api (ticdc): check --cert-allowed-cn before add server common name (#3628) (#3882)

* kvclient(ticdc): fix kvclient takes too long time to recover (#3612) (#3663)

* owner: fix owner tick block http request (#3490) (#3530)

* dm/syncer: use downstream PK/UK to generate DML (#3168) (#3256)

* dep(dm): update go-mysql (#3914) (#3934)

* dm/syncer: multiple rows use downstream schema (#3308) (#3953)

* errorutil,sink,syncer: add errorutil to handle ignorable error (#3264) (#3995)

* dm/worker: don't exit when failed to read checkpoint in relay (#3345) (#4005)

* syncer(dm): use an early location to reset binlog and open safemode (#3860)

* ticdc/owner: Fix ddl special comment syntax error (#3845) (#3978)

* dm/scheduler: fix inconsistent of relay status (#3474) (#4009)

* owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) (#4016)

* config(ticdc): Fix old value configuration check for maxwell protocol (#3747) (#3783)

* sink(ticdc): cherry pick sink bug fix to release 5.3 (#4083)

* master(dm): clean and treat invalid load task (#4004) (#4145)

* loader: fix wrong progress in query-status for loader (#4093) (#4143)

close #3252

* ticdc/processor: Fix backoff base delay misconfiguration (#3992) (#4028)

* dm: load table structure from dump files (#3295) (#4163)

* compactor: fix duplicate entry in safemode (#3432) (#3434) (#4088)

* kv(ticdc): reduce eventfeed rate limited log (#4072) (#4111)

close #4006

* metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (#4104)

* This is an automated cherry-pick of #4192

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* retry(dm): align with tidb latest error message (#4172) (#4254)

close #4159, close #4246

* owner(ticdc): Add bootstrap and try to fix the meta information in it (#3838) (#3865)

* redolog: add a precleanup process when s3 enable (#3525) (#3878)

* ddl(dm): make skipped ddl pass `SplitDDL()` (#4176) (#4227)

close #4173

* cdc/sink: remove Initialize method from the sink interface (#3682) (#3765)

Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>

* http_api (ticdc): fix http api 'get processor' panic. (#4117) (#4123)

close #3840

* sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (#4084) (#4099)

close #4055

* cdc/sink: adjust kafka initialization logic (#3192) (#4162)

* try fix conflicts.

* This is an automated cherry-pick of #4192

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* fix conflicts.

* fix conflicts.

Co-authored-by: zhaoxinyu <zhaoxinyu512@gmail.com>
Co-authored-by: amyangfei <yangfei@pingcap.com>
Co-authored-by: lance6716 <lance6716@gmail.com>
Co-authored-by: sdojjy <sdojjy@qq.com>
Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>
Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/metrics-logging needs-cherry-pick-release-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 release-note-none size/XXL status/can-merge status/LGT2