workerpool: limit the rate to output deadlock warning #3775

overvenus · 2021-12-07T13:23:22Z

What problem does this PR solve?

Close #2706

What is changed and how it works?

Ratelimit deadlock log.

Check List

Tests

Manual test (add detailed scripts or steps below)

Related changes

Need to cherry-pick to the release branch

Release note

Reduce log "synchronize is taking too long, report a bug" in some cases.

ti-chi-bot · 2021-12-07T13:23:24Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

amyangfei
liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

amyangfei

Does this PR need a test?

liuzix · 2021-12-08T02:31:19Z

pkg/workerpool/pool_impl.go

@@ -15,6 +15,7 @@ package workerpool

 import (
 	"context"
+	"golang.org/x/time/rate"


Should this be moved down to the second group of imports?

Signed-off-by: Neil Shen <overvenus@gmail.com>

amyangfei · 2021-12-08T07:02:45Z

/merge

ti-chi-bot · 2021-12-08T07:02:47Z

This pull request has been accepted and is ready to merge.

Commit hash: dc0f37f

overvenus · 2021-12-08T13:20:33Z

/merge

ti-chi-bot · 2021-12-08T13:20:36Z

This pull request has been accepted and is ready to merge.

Commit hash: a819919

overvenus · 2021-12-08T14:16:48Z

/run-kafka-integration-test
/run-integration-tests

ti-chi-bot · 2021-12-08T15:48:25Z

@overvenus: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

overvenus · 2021-12-08T16:29:29Z

/run-leak-test

ti-chi-bot · 2021-12-08T16:38:36Z

In response to a cherrypick label: new pull request created: #3795.

ti-chi-bot · 2021-12-08T16:39:13Z

In response to a cherrypick label: new pull request created: #3796.

ti-chi-bot · 2021-12-08T16:39:51Z

In response to a cherrypick label: new pull request created: #3797.

ti-chi-bot · 2021-12-08T16:40:30Z

In response to a cherrypick label: new pull request created: #3798.

ti-chi-bot · 2021-12-08T16:41:08Z

In response to a cherrypick label: new pull request created: #3799.

…ingcap#3798)

…ingcap#3799)

…ingcap#3795)

* fix the txn_batch_size metric inaccuracy bug when the sink target is MQ * address comments * add comments for exported functions * fix the compiling problem * workerpool: limit the rate to output deadlock warning (#3775) (#3799) * metrics: add changefeed checkepoint catch-up ETA (#3300) (#3311) * pkg,cdc: do not use log package (#3902) (#3939) * *: rename repo from pingcap/ticdc to pingcap/tiflow (#3957) * kvclient(ticdc): fix kvclient takes too long time to recover (#3612) (#3662) * tz (ticdc): fix timezone error (#3887) (#3910) * http_*: add log for http api and refine the err handle logic (#2997) (#3306) * ticdc/alert: add no owner alert rule (#3809) (#3831) * etcd_worker: batch etcd patch (#3277) (#3393) * ticdc/owner: Fix ddl special comment syntax error (#3845) (#3977) * Clean old owner and old processor in release 5.2 branch (#4019) * tests(ticdc): set up the sync diff output directory correctly (#3725) (#3745) * owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) (#4015) * config(ticdc): Fix old value configuration check for maxwell protocol (#3747) (#3782) * ticdc/processor: Fix backoff base delay misconfiguration (#3992) (#4027) * sink(ticdc): cherry pick sink bug fix to release 5.2 (#4083) (#4119) * metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (#4103) * kv(ticdc): reduce eventfeed rate limited log (#4072) (#4110) close #4006 * This is an automated cherry-pick of #4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * http_api (ticdc): fix http api 'get processor' panic. (#4117) (#4122) close #3840 * cdc/sink: adjust kafka initialization logic (#3192) (#3568) * This is an automated cherry-pick of #3192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix conflicts. * This is an automated cherry-pick of #3682 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix import. * fix failpoint path. * try to fix initialize. * remove table_sink. * remove initialization. * remove owner. * fix mq. Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> Co-authored-by: 3AceShowHand <jinl1037@hotmail.com> * sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (#4084) (#4098) close #4055 * This is an automated cherry-pick of #4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix conflicts. * fix conflicts. * fix conflicts. Co-authored-by: zhaoxinyu <zhaoxinyu512@gmail.com> Co-authored-by: amyangfei <yangfei@pingcap.com> Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com> Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>

* fix the txn_batch_size metric inaccuracy bug when the sink target is MQ * address comments * add comments for exported functions * fix the compiling problem * workerpool: limit the rate to output deadlock warning (#3775) (#3795) * tests(ticdc): set up the sync diff output directory correctly (#3725) (#3741) * relay(dm): use binlog name comparison (#3710) (#3712) * dm/load: fix concurrent call Loader.Status (#3459) (#3468) * cdc/sorter: make unified sorter cgroup aware (#3436) (#3439) * tz (ticdc): fix timezone error (#3887) (#3906) * pkg,cdc: do not use log package (#3902) (#3940) * *: rename repo from pingcap/ticdc to pingcap/tiflow (#3959) * http_*: add log for http api and refine the err handle logic (#2997) (#3307) * etcd_worker: batch etcd patch (#3277) (#3389) * http_api (ticdc): check --cert-allowed-cn before add server common name (#3628) (#3882) * kvclient(ticdc): fix kvclient takes too long time to recover (#3612) (#3663) * owner: fix owner tick block http request (#3490) (#3530) * dm/syncer: use downstream PK/UK to generate DML (#3168) (#3256) * dep(dm): update go-mysql (#3914) (#3934) * dm/syncer: multiple rows use downstream schema (#3308) (#3953) * errorutil,sink,syncer: add errorutil to handle ignorable error (#3264) (#3995) * dm/worker: don't exit when failed to read checkpoint in relay (#3345) (#4005) * syncer(dm): use an early location to reset binlog and open safemode (#3860) * ticdc/owner: Fix ddl special comment syntax error (#3845) (#3978) * dm/scheduler: fix inconsistent of relay status (#3474) (#4009) * owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) (#4016) * config(ticdc): Fix old value configuration check for maxwell protocol (#3747) (#3783) * sink(ticdc): cherry pick sink bug fix to release 5.3 (#4083) * master(dm): clean and treat invalid load task (#4004) (#4145) * loader: fix wrong progress in query-status for loader (#4093) (#4143) close #3252 * ticdc/processor: Fix backoff base delay misconfiguration (#3992) (#4028) * dm: load table structure from dump files (#3295) (#4163) * compactor: fix duplicate entry in safemode (#3432) (#3434) (#4088) * kv(ticdc): reduce eventfeed rate limited log (#4072) (#4111) close #4006 * metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (#4104) * This is an automated cherry-pick of #4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * retry(dm): align with tidb latest error message (#4172) (#4254) close #4159, close #4246 * owner(ticdc): Add bootstrap and try to fix the meta information in it (#3838) (#3865) * redolog: add a precleanup process when s3 enable (#3525) (#3878) * ddl(dm): make skipped ddl pass `SplitDDL()` (#4176) (#4227) close #4173 * cdc/sink: remove Initialize method from the sink interface (#3682) (#3765) Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> * http_api (ticdc): fix http api 'get processor' panic. (#4117) (#4123) close #3840 * sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (#4084) (#4099) close #4055 * cdc/sink: adjust kafka initialization logic (#3192) (#4162) * try fix conflicts. * This is an automated cherry-pick of #4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix conflicts. * fix conflicts. Co-authored-by: zhaoxinyu <zhaoxinyu512@gmail.com> Co-authored-by: amyangfei <yangfei@pingcap.com> Co-authored-by: lance6716 <lance6716@gmail.com> Co-authored-by: sdojjy <sdojjy@qq.com> Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>

workerpool: limit the rate to output deadlock warning

be723a2

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2021

overvenus requested review from liuzix and amyangfei December 7, 2021 13:23

amyangfei reviewed Dec 8, 2021

View reviewed changes

liuzix reviewed Dec 8, 2021

View reviewed changes

add a test

5768d3a

Signed-off-by: Neil Shen <overvenus@gmail.com>

ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2021

address comments

dc0f37f

Signed-off-by: Neil Shen <overvenus@gmail.com>

liuzix approved these changes Dec 8, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 8, 2021

amyangfei approved these changes Dec 8, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 8, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 8, 2021

Merge branch 'master' into fix-deadlock-log

68c199c

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 8, 2021

Merge branch 'master' into fix-deadlock-log

7afc32c

ti-chi-bot merged commit efe0c36 into pingcap:master Dec 8, 2021

ti-chi-bot mentioned this pull request Dec 8, 2021

workerpool: limit the rate to output deadlock warning (#3775) #3795

Merged

ti-chi-bot mentioned this pull request Dec 8, 2021

workerpool: limit the rate to output deadlock warning (#3775) #3796

Merged

ti-chi-bot mentioned this pull request Dec 8, 2021

workerpool: limit the rate to output deadlock warning (#3775) #3797

Merged

ti-chi-bot mentioned this pull request Dec 8, 2021

workerpool: limit the rate to output deadlock warning (#3775) #3798

Merged

ti-chi-bot mentioned this pull request Dec 8, 2021

workerpool: limit the rate to output deadlock warning (#3775) #3799

Merged

ti-chi-bot added a commit that referenced this pull request Dec 10, 2021

workerpool: limit the rate to output deadlock warning (#3775) (#3795)

961af87

ti-chi-bot added a commit that referenced this pull request Dec 10, 2021

workerpool: limit the rate to output deadlock warning (#3775) (#3799)

036ff34

ti-chi-bot added a commit that referenced this pull request Dec 10, 2021

workerpool: limit the rate to output deadlock warning (#3775) (#3798)

c4dc545

ti-chi-bot added a commit that referenced this pull request Dec 10, 2021

workerpool: limit the rate to output deadlock warning (#3775) (#3796)

0fbc2ac

ti-chi-bot added a commit that referenced this pull request Dec 10, 2021

workerpool: limit the rate to output deadlock warning (#3775) (#3797)

22e24a0

3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 25, 2021

workerpool: limit the rate to output deadlock warning (pingcap#3775) (p…

974aaa1

…ingcap#3798)

zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Dec 29, 2021

workerpool: limit the rate to output deadlock warning (pingcap#3775)

3aac109

3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 13, 2022

workerpool: limit the rate to output deadlock warning (pingcap#3775) (p…

db3d42e

…ingcap#3799)

3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 13, 2022

workerpool: limit the rate to output deadlock warning (pingcap#3775) (p…

339688e

…ingcap#3795)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

workerpool: limit the rate to output deadlock warning #3775

workerpool: limit the rate to output deadlock warning #3775

overvenus commented Dec 7, 2021

ti-chi-bot commented Dec 7, 2021 •

edited

Loading

amyangfei left a comment

liuzix Dec 8, 2021

amyangfei commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

overvenus commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

overvenus commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

overvenus commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

workerpool: limit the rate to output deadlock warning #3775

workerpool: limit the rate to output deadlock warning #3775

Conversation

overvenus commented Dec 7, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Dec 7, 2021 • edited Loading

amyangfei left a comment

Choose a reason for hiding this comment

liuzix Dec 8, 2021

Choose a reason for hiding this comment

amyangfei commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

overvenus commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

overvenus commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

overvenus commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

ti-chi-bot commented Dec 8, 2021

ti-chi-bot commented Dec 7, 2021 •

edited

Loading