-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: use values to reduce GC pressure (#2474) #2497
*: use values to reduce GC pressure (#2474) #2497
Conversation
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 97efb5d
|
Codecov Report
@@ Coverage Diff @@
## release-5.2 #2497 +/- ##
================================================
Coverage ? 55.8065%
================================================
Files ? 168
Lines ? 20494
Branches ? 0
================================================
Hits ? 11437
Misses ? 7956
Partials ? 1101 |
/merge |
/run-all-tests |
/run-integration-tests /run-kafka-tests |
/run-integration-tests |
/run-integration-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4481800
|
/run-integration-tests |
/run-integration-tests |
This is an automated cherry-pick of #2474
What problem does this PR solve?
Use prefer using values for channel types to reduce GC pressure. Same as #2415
Left: master
Right: this patch
Max (master): ~80ms
Max (this patch): ~35ms
Check List
Tests
Release note