-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipeline: use Message value to reduce GC pressure #2415
Conversation
Signed-off-by: Neil Shen <overvenus@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a benchmark in the unit test to verify the optimization for pipeline memory allocation
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
/run-all-tests |
/hold |
/unhold |
/run-kafka-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 22d835f
|
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #2439. |
In response to a cherrypick label: new pull request created: #2440. |
In response to a cherrypick label: new pull request created: #2441. |
What problem does this PR solve?
Use Message value to reduce GC pressure
Left: master
Right: this patch
Cc #2212
Check List
Tests
Related changes
Release note