Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink: add barrier in underlying sink to support accruate stop (#2417) #2495

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2417

What problem does this PR solve?

Fix #2230

This PR introduces a new Barrier API in sink interface, which is a synchronous function to wait all events to be flushed in underlying sink, note once Barrier is called, the resolved ts can't be pushed until the Barrier call returns.

We call Barrier when table sink is closing (via the Close method of table sink), and before Barrier is called, we draw back all existing events in sink buffer.

Note the cherry-pick cannot be merged into release-4.0, release-5.0 until new owner is enabled in these branches.

What is changed and how it works?

  • The Barrier implementation
    • MySQL sink: wait checkpoint-ts to reach max received resolved-ts
    • MQ sink: TODO
  • Drawback mechanism in buffer sink
    • Buffer sink stores rows by table in memory, and emit rows to underlying sink only resolved ts is forwarded.
    • Hook a channel from sink manager to notify buffer sink to draw back rows of a table, and wait callback

Check List

Tests

  • Unit test
  • Integration test

Release note

Fix a bug that multiple processors could write the same table when this table is re-scheduling

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 10, 2021
@ti-chi-bot ti-chi-bot added release-blocker This issue blocks a release. Please solve it ASAP. require-LGT1 Indicates that the PR requires an LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Aug 10, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 10, 2021
@amyangfei amyangfei added this to the v4.0.15 milestone Aug 11, 2021
@amyangfei amyangfei force-pushed the cherry-pick-2417-to-release-4.0 branch from 8dc843e to a68dc14 Compare August 12, 2021 06:09
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 12, 2021
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 12, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: a68dc14

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 12, 2021
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2495 (25a2128) into release-4.0 (753073a) will increase coverage by 1.2600%.
The diff coverage is 57.4182%.

@@                 Coverage Diff                 @@
##           release-4.0      #2495        +/-   ##
===================================================
+ Coverage      53.7661%   55.0261%   +1.2600%     
===================================================
  Files              153        162         +9     
  Lines            15958      19478      +3520     
===================================================
+ Hits              8580      10718      +2138     
- Misses            6475       7738      +1263     
- Partials           903       1022       +119     

@ti-chi-bot ti-chi-bot merged commit fb5130e into pingcap:release-4.0 Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-blocker This issue blocks a release. Please solve it ASAP. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants