-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink: add barrier in underlying sink to support accruate stop #2417
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-integration-tests |
1 similar comment
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #2417 +/- ##
================================================
- Coverage 57.0620% 55.7170% -1.3450%
================================================
Files 165 168 +3
Lines 19435 20570 +1135
================================================
+ Hits 11090 11461 +371
- Misses 7288 8006 +718
- Partials 1057 1103 +46 |
/run-all-tests |
/run-integration-tests |
/unhold |
@ben1009: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d230dea
|
/run-kafka-tests |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #2492. |
In response to a cherrypick label: new pull request created: #2493. |
In response to a cherrypick label: new pull request created: #2494. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #2495. |
What problem does this PR solve?
Fix #2230
This PR introduces a new
Barrier
API in sink interface, which is a synchronous function to wait all events to be flushed in underlying sink, note onceBarrier
is called, the resolved ts can't be pushed until the Barrier call returns.We call
Barrier
when table sink is closing (via theClose
method of table sink), and beforeBarrier
is called, we draw back all existing events in sink buffer.Note the cherry-pick cannot be merged into release-4.0, release-5.0 until new owner is enabled in these branches.
What is changed and how it works?
Barrier
implementationCheck List
Tests
Release note