mark processor down for some time not updating resolve ts #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#154 is merged now, pls resolved the conflict |
zier-one
reviewed
Dec 6, 2019
| } | ||
|
|
||
| func (o *ownerImpl) removeCapture(info *model.CaptureInfo) { | ||
| o.l.Lock() | ||
| delete(o.captures, info.ID) |
amyangfei
reviewed
Dec 10, 2019
| } | ||
|
|
||
| oldPinfo, ok := cfInfo.ProcessorInfos[cid] | ||
| if !ok || oldPinfo.ResolvedTs != pinfo.ResolvedTs { |
There was a problem hiding this comment.
both ResolvedTs and CheckpointTs change can trigger the update of last update time?
There was a problem hiding this comment.
only check ResolvedTS here do you means check it both?
There was a problem hiding this comment.
if !ok || oldPinfo.ResolvedTs != pinfo.ResolvedTs || oldPinfo.CheckpointTs != pinfo.CheckpointTs
like this?
amyangfei
reviewed
Dec 10, 2019
| @@ -34,6 +35,8 @@ import ( | |||
| "go.uber.org/zap" | |||
| ) | |||
|
|
|||
| var markProcessorDownTime = time.Minute | |||
There was a problem hiding this comment.
It seems the interval that processor updates resolvedTs or checkpointTs is not always less than 1 minute. Besides shall we allow several times update failure of processor and do we need to increase this value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
review after #154
mark processor down for some time not updating resolve ts
What is changed and how it works?
mark processor down for some time not updating resolve ts.
and clear up data dispatch tables to other captures laster.
Check List
Tests