owner: add lock control in owner table info writer #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls resolve conflict |
july2993
reviewed
Dec 4, 2019
| if writePLock { | ||
| newInfo.TablePLock = &model.TableLock{ | ||
| Ts: oracle.EncodeTSO(time.Now().UnixNano() / int64(time.Millisecond)), | ||
| CreatorID: util.CaptureIDFromCtx(ctx), |
There was a problem hiding this comment.
I will prefer explicitly param here, but ok with this too now.
suzaku
reviewed
Dec 5, 2019
cdc/owner.go
Outdated
| subInfo.RemoveTable(id) | ||
|
|
||
| newInfo, err := c.infoWriter.Write(ctx, c.ID, captureID, subInfo, true) | ||
| c.ProcessorInfos[captureID] = newInfo |
There was a problem hiding this comment.
Only set it when err != nil? If newInfo is nil on error, later calls to restoreTableInfos may end in runtime error.
5kbpers
pushed a commit
to 5kbpers/ticdc
that referenced
this pull request
Aug 24, 2020
amyangfei
pushed a commit
to amyangfei/tiflow
that referenced
this pull request
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When owner add or remove a table to subchangefeedinfo in etcd, it should concern the
table-p-lock.Owner also needs to guarantee local
SubChangeFeedInfois up to date before writing new data into etcd.What is changed and how it works?
table-p-lockis not resolved, wait for it resolved.table-p-lockis resolved, remove bothtable-p-lockandtable-c-lockfrom etcd.Check List
Tests