sorter: Stabilize Unified Sorter (#1210) #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
component/puller
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1230 +/- ##
===================================================
- Coverage 45.9675% 44.5555% -1.4120%
===================================================
Files 112 125 +13
Lines 11767 12802 +1035
===================================================
+ Hits 5409 5704 +295
- Misses 5747 6465 +718
- Partials 611 633 +22 |
|
/run-all-tests |
|
/run-all-tests |
|
LGTM |
amyangfei
approved these changes
Jan 6, 2021
ti-srebot
added
status/LGT2
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1210 to release-4.0
What problem does this PR solve?
What is changed and how it works?
WorkerPoolis implemented to provide a mechanism in which one Goroutine can process events from multiple sources.Check List
Tests
Code changes
Side effects
Related changes
Release note