sorter: Stabilize Unified Sorter #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuzix
added
status/WIP
status/ptal
liuzix
changed the title
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
…dc into zixiong-unified-sorter-stable
|
/run-all-tests |
ti-srebot
approved these changes
Dec 23, 2020
amyangfei
reviewed
Dec 23, 2020
tests/cdclog_s3/run.sh
Outdated
| @@ -16,6 +16,7 @@ export AWS_SECRET_ACCESS_KEY=$MINIO_SECRET_KEY | |||
| export S3_ENDPOINT=127.0.0.1:24927 | |||
| rm -rf "$WORK_DIR" | |||
| mkdir -p "$WORK_DIR" | |||
| pkill -9 minio | |||
There was a problem hiding this comment.
Suggested change
| pkill -9 minio | |
| pkill -9 minio || true |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Dec 24, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #1230 |
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Dec 24, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.0-rc in PR #1231 |
ti-srebot
added a commit
that referenced
this pull request
Dec 24, 2020
ti-srebot
added a commit
that referenced
this pull request
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
WorkerPoolis implemented to provide a mechanism in which one Goroutine can process events from multiple sources.Check List
Tests
Code changes
Side effects
Related changes
Release note