Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Using the global singleton for pd client and tikv client, and fix pd client freeze (#1217) #1220

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #1217 to release-5.0


What problem does this PR solve?

Using the global singleton for pd client and tikv client, and fix pd client freeze

What is changed and how it works?

The modification of this PR bypasses the bug about pd client freeze by using a global singleton for pd client

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Fix the bug of possible TiCDC server freeze

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added type/bugfix This PR fixes a bug. status/ptal Could you please take a look? type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Dec 16, 2020
@ti-srebot ti-srebot added this to the v5.0.0-alpha milestone Dec 16, 2020
@overvenus
Copy link
Member

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 16, 2020
@amyangfei amyangfei merged commit bbb6aa5 into pingcap:release-5.0 Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look? type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants