*: Using the global singleton for pd client and tikv client, and fix pd client freeze #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zier-one
added
needs-cherry-pick-release-4.0
|
Please add some tests. |
|
LGTM. If we do want tests, can we assert that we only have one pdClient globally by comparing pointers? |
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #1217 +/- ##
================================================
+ Coverage 46.2837% 46.3076% +0.0238%
================================================
Files 115 115
Lines 11961 11957 -4
================================================
+ Hits 5536 5537 +1
+ Misses 5801 5794 -7
- Partials 624 626 +2 |
|
It's hard to unit test in current code base, can we test it in integration tests via failpoint? |
|
LGTM |
ti-srebot
approved these changes
Dec 16, 2020
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Dec 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #1219 |
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Dec 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.0 in PR #1220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Using the global singleton for pd client and tikv client, and fix pd client freeze
What is changed and how it works?
The modification of this PR bypasses the bug about pd client freeze by using a global singleton for pd client
Check List
Tests
Release note